FlowKit icon indicating copy to clipboard operation
FlowKit copied to clipboard

Lockfiles getting out of sync

Open greenape opened this issue 6 years ago • 4 comments

If dependabot updates the lock file for flowmachine's Pipfile, then the lock files in integration tests and docs will be out of sync with flowmachine's. Same will happen if we add a package to one of the child project lock files.

greenape avatar Feb 27 '19 14:02 greenape

(Can't think of any obvious way to fix that, but worth mentioning)

greenape avatar Feb 27 '19 14:02 greenape

Possible solution - remove flowmachine etc. from the integration test and docs pipfiles, install their dependencies using bash thus:

PIPENV_PIPFILE="../flowapi/Pipfile" pipenv install --ignore-pipfile and the packages themselves so: pipenv install --skip-lock ../flowapi

Bit of a pain for running tests docs in PyCharm, because you need to make sure the install gets invoked. Doesn't protect you where an automated update updates a dependency of both, because it'll only update it in one, and the version you'd end up running the tests with will be the one from whichever was last in the script.

greenape avatar Mar 07 '19 10:03 greenape

https://github.com/dependabot/feedback/issues/460

greenape avatar May 09 '19 20:05 greenape

This by itself is a major argument in favour of migrating away from our monorepo.

greenape avatar Sep 23 '21 10:09 greenape