Flowise icon indicating copy to clipboard operation
Flowise copied to clipboard

handles scenario where NodesPool require call fails

Open Jaredude opened this issue 1 year ago • 1 comments

Currently, the following file results in an error: Flowise/packages/components/dist/nodes/documentloaders/Subtitles/Subtitles.js:3:15 The result is that initializeNodes fails completely, and all other code in initDatabase fails to load

Jaredude avatar Feb 22 '24 03:02 Jaredude

@HenryHengZJ This bug fix does not address the issue with Subtitles that is causing initializeNodes to fail. Instead, this solution prevents a single node failing to load in initializeNodes from preventing the entire server to initialize properly. This way, if another node has an issue in the future, the server initialization will still function properly. I'll take a separate look at Subtitles and make a different PR as needed.

This is the error I was seeing in my server log Screenshot 2024-02-21 at 9 28 15 PM

Jaredude avatar Feb 22 '24 03:02 Jaredude

thanks @Jaredude! yeah wrapping in try catch can at least let the data source initialiation finish

HenryHengZJ avatar Feb 24 '24 09:02 HenryHengZJ