Button node passing on the msg.ui_update property that it previously received

[Just-another-pleb]

Current Behavior

The button node is sending ui_update properties from a previous incoming message.

Expected Behavior

This shouldn't happen.

Steps To Reproduce

Example code:

[{"id":"eb989fcd67e25fa7","type":"inject","z":"b39000460508d582","name":"","props":[{"p":"payload"},{"p":"topic","vt":"str"}],"repeat":"","crontab":"","once":false,"onceDelay":0.1,"topic":"","payload":"0","payloadType":"num","x":5320,"y":810,"wires":[["9ac368e01da4aa5f"]]},{"id":"9ac368e01da4aa5f","type":"change","z":"b39000460508d582","name":"Normal","rules":[{"t":"set","p":"ui_update.label","pt":"msg","to":"PASS","tot":"str"},{"t":"set","p":"ui_update.buttonColor","pt":"msg","to":"blue","tot":"str"},{"t":"delete","p":"payload","pt":"msg"}],"action":"","property":"","from":"","to":"","reg":false,"x":5450,"y":870,"wires":[["020352927c165a64"]]},{"id":"e00e37f0d00a65c8","type":"change","z":"b39000460508d582","name":"Hold","rules":[{"t":"set","p":"ui_update.label","pt":"msg","to":"HOLD","tot":"str"},{"t":"set","p":"ui_update.buttonColor","pt":"msg","to":"red","tot":"str"},{"t":"delete","p":"payload","pt":"msg"}],"action":"","property":"","from":"","to":"","reg":false,"x":5440,"y":910,"wires":[["020352927c165a64"]]},{"id":"35a8e73703cbc8c0","type":"inject","z":"b39000460508d582","name":"","props":[{"p":"payload"},{"p":"topic","vt":"str"}],"repeat":"","crontab":"","once":false,"onceDelay":0.1,"topic":"","payload":"1","payloadType":"num","x":5320,"y":950,"wires":[["e00e37f0d00a65c8"]]},{"id":"020352927c165a64","type":"ui-button","z":"b39000460508d582","group":"6f4a6f88bfbb219b","name":"Hold","label":"","order":10,"width":"1","height":"1","emulateClick":false,"tooltip":"","color":"","bgcolor":"","className":"","icon":"","iconPosition":"left","payload":"X","payloadType":"str","topic":"topic","topicType":"msg","buttonColor":"","textColor":"","iconColor":"","enableClick":true,"enablePointerdown":false,"pointerdownPayload":"","pointerdownPayloadType":"str","enablePointerup":false,"pointerupPayload":"","pointerupPayloadType":"str","x":5610,"y":890,"wires":[["a888ea107ac7f3bb","52ba28d889a8d6fb"]]},{"id":"52ba28d889a8d6fb","type":"ui-text","z":"b39000460508d582","group":"6f4a6f88bfbb219b","order":12,"width":"2","height":"1","name":"","label":"Test","format":"{{msg.payload}}","layout":"row-spread","style":false,"font":"","fontSize":16,"color":"#717171","wrapText":false,"className":"","x":5870,"y":890,"wires":[]},{"id":"6f4a6f88bfbb219b","type":"ui-group","name":"Group 1","page":"b9b507aa5c5840c2","width":"10","height":1,"order":1,"showTitle":false,"className":"","visible":true,"disabled":"false","groupType":"default"},{"id":"b9b507aa5c5840c2","type":"ui-page","name":"Down/Up load speed tester","ui":"379027033ed5c83a","path":"/page1","icon":"home","layout":"flex","theme":"84a68e3f4c6f8cdc","breakpoints":[{"name":"Default","px":"0","cols":"3"},{"name":"Tablet","px":"576","cols":"6"},{"name":"Small Desktop","px":"768","cols":"9"},{"name":"Desktop","px":"1024","cols":"12"}],"order":1,"className":"","visible":true,"disabled":false},{"id":"379027033ed5c83a","type":"ui-base","name":"My Dashboard","path":"/dashboard","appIcon":"","includeClientData":true,"acceptsClientConfig":["ui-notification","ui-control"],"showPathInSidebar":false,"headerContent":"page","navigationStyle":"default","titleBarStyle":"default","showReconnectNotification":true,"notificationDisplayTime":1,"showDisconnectNotification":true,"allowInstall":true},{"id":"84a68e3f4c6f8cdc","type":"ui-theme","name":"Default Theme","colors":{"surface":"#63452c","primary":"#0094ce","bgPage":"#63452c","groupBg":"#63452c","groupOutline":"#cccccc"},"sizes":{"density":"default","pagePadding":"12px","groupGap":"12px","groupBorderRadius":"4px","widgetGap":"12px"}}]

Environment

• Dashboard version: 1.24.0
• Node-RED version: 4.0.9
• Node.js version: 20.19.4
• npm version: 10.8.2
• Platform/OS: Ubuntu 22.04.5 LTS
• Browser: firefox

Have you provided an initial effort estimate for this issue?

I have provided an initial effort estimate