flowfuse icon indicating copy to clipboard operation
flowfuse copied to clipboard

Full Height Pages

Open cstns opened this issue 9 months ago • 1 comments

Description

Parent pr that serves as a starting point and target branch for subsequent PR's that handle the full height changes

Related Issue(s)

N/A

Checklist

  • [ ] I have read the contribution guidelines
  • [ ] Suitable unit/system level tests have been added and they pass
  • [ ] Documentation has been updated
    • [ ] Upgrade instructions
    • [ ] Configuration details
    • [ ] Concepts
  • [ ] Changes flowforge.yml?
    • [ ] Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • [ ] Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • [ ] Includes a DB migration? -> add the area:migration label

cstns avatar Mar 24 '25 09:03 cstns

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 77.43%. Comparing base (999a684) to head (95d7c08). Report is 46 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5345      +/-   ##
==========================================
+ Coverage   77.37%   77.43%   +0.06%     
==========================================
  Files         351      354       +3     
  Lines       16682    16735      +53     
  Branches     3897     3910      +13     
==========================================
+ Hits        12907    12959      +52     
- Misses       3775     3776       +1     
Flag Coverage Δ
backend 77.43% <ø> (+0.06%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Mar 24 '25 10:03 codecov[bot]

@cstns I'm reviewing this now

joepavitt avatar May 14 '25 08:05 joepavitt

Screenshot 2025-05-14 at 09 56 31

The scroll zone for the "Remote Instances" page is off

joepavitt avatar May 14 '25 08:05 joepavitt

Few minor fixes and removing of some (now) defunct mb-14's that were being used to provide spacing around forms and tables. Given the full page height, that now does a better job.

joepavitt avatar May 14 '25 09:05 joepavitt

Awaiting final E2E pass before merging

joepavitt avatar May 14 '25 09:05 joepavitt

The scroll zone for the "Remote Instances" page is off

I'll have to through pages one at a time and fix any scrolling misbehavior either way but they can be done after

cstns avatar May 14 '25 09:05 cstns

I'll have to through pages one at a time and fix any scrolling misbehavior either way but they can be done after

I fixed them all :)

joepavitt avatar May 14 '25 09:05 joepavitt

@cstns mind jumping in to fix the test please? It seems linked to that fact it's trying to scroll the nested table, not the main element.

joepavitt avatar May 14 '25 09:05 joepavitt