Clarify "Push to stage" dialog env var statement

[Steve-Mcl]

closes #4603

Description

Clarify "Push to stage" dialog env var statement

Before:

After:

Related Issue(s)

#4603

Checklist

• [x] I have read the contribution guidelines
• [ ] Suitable unit/system level tests have been added and they pass
• [ ] Documentation has been updated
  • [ ] Upgrade instructions
  • [ ] Configuration details
  • [ ] Concepts
• [ ] Changes flowforge.yml?
  • [ ] Issue/PR raised on FlowFuse/helm to update ConfigMap Template
  • [ ] Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

• [ ] Includes a DB migration? -> add the area:migration label

[cstns]

Feel free to merge after tests pass

[codecov[bot]]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 78.74%. Comparing base (f52c2cc) to head (059c0a2). Report is 6 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #4604   +/-   ##
=======================================
  Coverage   78.74%   78.74%           
=======================================
  Files         311      311           
  Lines       14669    14669           
  Branches     3354     3354           
=======================================
  Hits        11551    11551           
  Misses       3118     3118           

Flag	Coverage Δ
backend	78.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

[Steve-Mcl]

Thanks @cstns appreciate quick feedback.

Hoping to also get the "OK" from @joepavitt and perhaps @sumitshinde-84 too since it arose from confusion in the new pipelines article here: https://github.com/FlowFuse/website/pull/2603#discussion_r1784057978

[joepavitt]

First one states that keys will transfer, but the values will not. Now, the new one states that keys will not be overwritten, but that implies the values will?

[joepavitt]

@Steve-Mcl just chasing for a reply to my comment above

[Steve-Mcl]

Now, the new one states that keys will not be overwritten, but that implies the values will?

Thats not what i (and the other guys who discussed this on Slack) infer from it ;) but since you did, perhaps a simplification would be better?

Environment variables in the target instance that already have a value will not be overwritten

Clean, to the point.

More explicit?:

Environment variables will be copied to the target instance but any that already have a value will not be overwritten.

Super precise?:

Environment Variables will be copied from the source to the target instance. Any Environment Variables that the target already has will not be overwritten if they contain a value however empty Environment Variables will be updated.

Thoughts?

[joepavitt]

Environment variables in the target instance that already have a value will not be overwritten

This please

[Steve-Mcl]

Environment variables in the target instance that already have a value will not be overwritten

This please

Done diddly done.

a0e93c4