4511 bulk read notifications
Description
bulk mark read/unread notifications
- api endpoint
- ui
Related Issue(s)
closes https://github.com/FlowFuse/flowfuse/issues/4511
Checklist
- [x] I have read the contribution guidelines
- [x] Suitable unit/system level tests have been added and they pass
- [ ] Documentation has been updated
- [ ] Upgrade instructions
- [ ] Configuration details
- [ ] Concepts
- [ ] Changes
flowforge.yml?- [ ] Issue/PR raised on
FlowFuse/helmto update ConfigMap Template - [ ] Issue/PR raised on
FlowFuse/CloudProjectto update values for Staging/Production
- [ ] Issue/PR raised on
Labels
- [ ] Includes a DB migration? -> add the
area:migrationlabel
Codecov Report
Attention: Patch coverage is 90.90909% with 2 lines in your changes missing coverage. Please review.
Project coverage is 78.44%. Comparing base (
8cf9231) to head (3822f0d). Report is 26 commits behind head on main.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| forge/db/models/Notification.js | 77.77% | 2 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## main #4601 +/- ##
==========================================
+ Coverage 78.42% 78.44% +0.02%
==========================================
Files 302 303 +1
Lines 14337 14356 +19
Branches 3259 3264 +5
==========================================
+ Hits 11244 11262 +18
- Misses 3093 3094 +1
| Flag | Coverage Δ | |
|---|---|---|
| backend | 78.44% <90.90%> (+0.02%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Also, since we are affecting APIs, we might want Nick @knolleary to glance over the schema before merging?
PS,
almost forgot:
- reference a changelog entry on the website repo in here somewhere (preferably the OP)
- are there any docs in this repo related to notification that need updating?
- this can be a branched PR
* reference a changelog entry on the website repo in here somewhere (preferably the OP) * are there any docs in this repo related to notification that need updating?
Did not find any docs related to user notifications. I added a changelog pr which I referenced in a tasklist on the parent issue.
Also, since we are affecting APIs, we might want Nick @knolleary to glance over the schema before merging?
Should I postpone merging the PR until we get a green light from @knolleary ?
@cstns some quick feedback:
- Please set a proper PR title as these end up in the changelog. For example, not having the issue number in the title and a clear short description of what this PR does - eg 'Add ability to mark multiple notitications as read'
- When adding new external APIs please add a summary of the endpoint to the PR description to help review process - either in the PR or the related issue.
Please address the first item before merging - and take on the second item as feedback for future work.
Is it ok to merge as is or should I wait for the deployment action to get resolved?
Depends what testing/verification its had between you and @Steve-Mcl - I think its relatively low risk to ship as-is.
@cstns retested in pre-staging - still good to go (once merge and tests go green)