flowfuse icon indicating copy to clipboard operation
flowfuse copied to clipboard

4563 replace instance and audit logs dropdowns

Open cstns opened this issue 1 year ago • 2 comments

Description

Related Issue(s)

closes https://github.com/FlowFuse/flowfuse/issues/4563

Checklist

  • [x] I have read the contribution guidelines
  • [x] Suitable unit/system level tests have been added and they pass
  • [ ] Documentation has been updated
    • [ ] Upgrade instructions
    • [ ] Configuration details
    • [ ] Concepts
  • [ ] Changes flowforge.yml?
    • [ ] Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • [ ] Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • [ ] Includes a DB migration? -> add the area:migration label

cstns avatar Sep 25 '24 10:09 cstns

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 78.74%. Comparing base (a92555d) to head (0c5343d). Report is 34 commits behind head on main.

Files with missing lines Patch % Lines
forge/db/models/AuditLog.js 75.00% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4567      +/-   ##
==========================================
- Coverage   78.74%   78.74%   -0.01%     
==========================================
  Files         314      314              
  Lines       15093    15090       -3     
  Branches     3476     3473       -3     
==========================================
- Hits        11885    11882       -3     
  Misses       3208     3208              
Flag Coverage Δ
backend 78.74% <75.00%> (-0.01%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


🚨 Try these New Features:

codecov[bot] avatar Sep 25 '24 10:09 codecov[bot]

It wasn't oversight, It's just the crazy way I managed to split the input's when creating the tasks, Should be fixed by https://github.com/FlowFuse/flowfuse/issues/4561

cstns avatar Sep 27 '24 12:09 cstns

@cstns are we merging this? ~~It is ready to go now~~ nvm, e2e test fails!

Steve-Mcl avatar Oct 24 '24 09:10 Steve-Mcl

We will not, there's something wrong with the audit log user selector which the e2e tests picked up. Will look at it in more depth after the release

cstns avatar Oct 24 '24 09:10 cstns

should be good to go after everything goes green

cstns avatar Nov 22 '24 12:11 cstns