flowfuse icon indicating copy to clipboard operation
flowfuse copied to clipboard

Fix browser history when accessing the immersive editor

Open cstns opened this issue 1 year ago • 1 comments

Current Behavior

When accessing the immersive editor, multiple instances of the page are pushed into the browser's history causing difficulties when users want to navigate back to the previous page.

Expected Behavior

Users should one click the back button after accessing the immersive editor

Steps To Reproduce

Open the immersive editor and check browser history

Environment

  • FlowFuse version: 2.8.0
  • Node.js version: N/A
  • npm version: N/A
  • Platform/OS: N/A
  • Browser: N/A

Have you provided an initial effort estimate for this issue?

I have provided an initial effort estimate

cstns avatar Sep 25 '24 07:09 cstns

The browser's history is impacted by the oAuth authentication procedure between the instance and the FlowFuse platform in which two redirects occur (one in /account/authorize and the second in /account/complete/:code).

For the time being, I have no practical solution on how to solve this, or if it should be solved as it's a core component in the auth process.

cstns avatar Sep 26 '24 07:09 cstns

@knolleary, I assigned you as well so we won't loose track of it

cstns avatar Nov 22 '24 12:11 cstns

not something we can easily fix, moving it to todo as other priorities take precedence

cstns avatar Jan 16 '25 14:01 cstns

We've been carrying over this over multiple release versions and has no urgency or immediate fix that can be addressed as the oauth redirect is integral to the NR authentication process.

We should remove it from the current release and re-schedule it when needed.

cstns avatar Sep 09 '25 08:09 cstns