Additional-Buildcraft-Objects-Mod icon indicating copy to clipboard operation
Additional-Buildcraft-Objects-Mod copied to clipboard
verified publisher icon Flow86

LiquidHopper

Open rubensworks opened this issue 12 years ago • 4 comments

I've implemented the LiquidHopper as mentioned in https://github.com/BuildCraft/BuildCraft/issues/1291 and https://github.com/BuildCraft/BuildCraft/pull/1310 in the BuildCraft repo. It seems like the main BuildCraft devs didn't like it after all, so if you want you're welcome to add it to ADO.

The code for it can be found in my fork of BuildCraft: https://github.com/rubensworks/BuildCraft/commit/80ab099b9bcf04d9213e1e5ae7184564a82412a7

I don't know if you would need anything else?

rubensworks avatar Nov 04 '13 18:11 rubensworks

Sounds good to add, I will do it in a few days. Too much work this week :/

Flow86 avatar Nov 04 '13 20:11 Flow86

It's not that they didn't necessarily like it. You just have to discuss changes in mechanics with the devs first BEFORE submitting a PR.

nevercast avatar Nov 04 '13 23:11 nevercast

Well, the feature request issue was open for quite a while. I also couldn't find any information on how to directly contact the main devs.

rubensworks avatar Nov 05 '13 07:11 rubensworks

IRC, #buildcraft, irc.esper.net. Learn to IRC :)

nevercast avatar Nov 05 '13 22:11 nevercast