Flow.Launcher icon indicating copy to clipboard operation
Flow.Launcher copied to clipboard

Clearing Launcher Hotkey does not disable existing hotkey

Open jeremymeyers opened this issue 4 years ago • 8 comments

Describe the bug/issue After hitting the "X" button on "Flow Launcher Hotkey" in the config screen, the hotkey you just cleared will still bring up the Launcher

To Reproduce Steps to reproduce the behavior:

  1. Navigate to the "Hotkey" section of setup
  2. Assign a hotkey (like Home button)
  3. Hit the X button (it will say "Success"
  4. Press the old hotkey

Screenshots If applicable, add screenshots to help explain your problem.

Your System

Windows build number: 10.0.19043 N/A Build 19043
Flow Launcher version: 1.8.3

jeremymeyers avatar Nov 16 '21 17:11 jeremymeyers

I'll check. You were trying to make a situation where there was no shortcut key at all, right?

I'm planning If the focus is lost without any content, I considering opening a confirmation window to "remove the shortcut key at all?". or whole redesign hotkey like powertoy.

onesounds avatar Nov 16 '21 22:11 onesounds

maybe the behaviour on clicking X should be returning it to the previously set hotkey, because you always need a hotkey to trigger flow, unless we allow no hotkey configuration.

jjw24 avatar Nov 17 '21 20:11 jjw24

maybe the behaviour on clicking X should be returning it to the previously set hotkey, because you always need a hotkey to trigger flow, unless we allow no hotkey configuration.

true. But I think there will be some situations where it needs to be removed. (powertoy : impossible / fluent and etc : possible) Of course, the easy way is just block the way to remove it.

If there is no problem removing the shortcut (I'll test it), I will work on some UIs. (confirm popup, warning UI, etc.) also I think there will be necessary situations when playing games, so it would be good to have a temporary deactivation function through the tray menu. I'll think about it because the priority is low.

onesounds avatar Nov 17 '21 21:11 onesounds

ok sounds good

jjw24 avatar Nov 17 '21 21:11 jjw24

I'll check. You were trying to make a situation where there was no shortcut key at all, right?

I'm planning If the focus is lost without any content, I considering opening a confirmation window to "remove the shortcut key at all?". or whole redesign hotkey like powertoy.

Well more like i'd accidently set the hotkey to the spacebar and needed to clear it out.

My original goal was to set the hotkey to windowskey+SpaceBar but that doesn't seem possible.

Would also like to suggest (Tho this might need its own report) that if you arent actually able to manually type into the hotkey box (like if i wanted to just type "Alt + Spacebar") that there should be some visual cue that it is not a standard textbox as used elsewhere in the config

jeremymeyers avatar Nov 19 '21 19:11 jeremymeyers

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

github-actions[bot] avatar Jun 09 '22 02:06 github-actions[bot]

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

github-actions[bot] avatar Jul 11 '22 02:07 github-actions[bot]

This issue is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 5 days.

github-actions[bot] avatar Aug 26 '22 02:08 github-actions[bot]

This issue is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 5 days.

github-actions[bot] avatar Oct 19 '22 02:10 github-actions[bot]

This issue is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 5 days.

github-actions[bot] avatar Dec 10 '22 01:12 github-actions[bot]

This issue was closed because it has been stale for 7 days with no activity. If you feel this issue still needs attention please feel free to reopen.

github-actions[bot] avatar Dec 31 '22 01:12 github-actions[bot]

This issue is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 5 days.

github-actions[bot] avatar Feb 20 '23 02:02 github-actions[bot]

@jjw24 fixed recently? Ok to close?

deefrawley avatar Mar 04 '23 06:03 deefrawley

@jjw24 fixed recently? Ok to close?

It's not fixed yet - I putting it off because we need to fix the hotkey registration UI overall. It's a lot of work.

onesounds avatar Mar 04 '23 17:03 onesounds

No worries, let's leave it open

deefrawley avatar Mar 04 '23 22:03 deefrawley

This issue is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 5 days.

github-actions[bot] avatar Jan 05 '24 01:01 github-actions[bot]

Should have been fixed. Feel free to reopen if still persists.

VictoriousRaptor avatar Jan 06 '24 05:01 VictoriousRaptor