Flow.Launcher icon indicating copy to clipboard operation
Flow.Launcher copied to clipboard

Remove other search precision levels

Open taooceros opened this issue 3 years ago • 20 comments

Discussed in https://github.com/Flow-Launcher/Flow.Launcher/discussions/517

Originally posted by jjw24 April 25, 2020 Unless I am wrong, other search precision levels- None, Low are not used much by user base. This assumption is that precision level saving is broken and no one has put forward an issue about it in the JJW24 fork.

image

Removing others can help simplify logic and focus on fine tuning the search for one level going forward.

taooceros avatar Jun 28 '21 11:06 taooceros

Wrong! I use None, as otherwise some of my results are not being shown properly, e.g. programms using Umlauts or searching for special chars. E.g. when I want to open Notepad++ I type ++, but this only shows the app when setting precision to "None" or low

skjerns avatar Jul 30 '21 09:07 skjerns

Can you give me some examples of the searches you are not getting with regular

Also what version of flow you are currently using

jjw24 avatar Jul 30 '21 11:07 jjw24

I'm using 1.8.1, I just checked the forum as each version update resets my settings for the precision value.

I can see if I can remember more cases, but for that I need to turn it off and wait a few days. I just remember it being totally off on some queries and giving strange results last year, so I switched to "None". But might be fixed by now (except for the ++ case)

skjerns avatar Jul 30 '21 11:07 skjerns

Probably the storage of SearchPrecision setting contains an issue. Will take a look on that soon.

taooceros avatar Jul 30 '21 12:07 taooceros

Yeah I never use this feature, I always use the default. We should strive for a good default first and options later.

If User fails to find a item with a reasonable query, it should be consider bug.

pc223 avatar Aug 10 '21 23:08 pc223

... We should strive for a good default first and options later.

If User fails to find a item with a reasonable query, it should be consider bug.

agree, absolutely.

jjw24 avatar Aug 11 '21 03:08 jjw24

... E.g. when I want to open Notepad++ I type ++, but this only shows the app when setting precision to "None" or low

hmm mine comes up with notepad++ via querying '++'

image

But no, a fresh install will not have this come up. So it's the frequency of use that helped boost my everyday Flow to show with the '++' query.

jjw24 avatar Aug 11 '21 03:08 jjw24

I agree!

my problem is, that ++ doesn't ever show up Notepad if setting to regular, so I can't really increase the frequency and "train" it. Strangely enough, the c++ compiler shows up! I have the exact same problem on different machines, so it's not just a local problem

skjerns avatar Aug 11 '21 04:08 skjerns

my problem is, that ++ doesn't ever show up Notepad if setting to regular

Hm, weird, I tried a fresh install of 1.8.1, seems notepad++ still show in the bottom (with regular on)

pc223 avatar Aug 11 '21 09:08 pc223

Hm, weird, I tried a fresh install of 1.8.1, seems notepad++ still show in the bottom (with regular on)

On fresh install, if you query 'notepad++' it will show somewhere on the list for sure, but you will never get it with '++' query, and consequently you cant as @skjerns mentions, train it with frequency to show up higher when query '++'. Our search algorithm never designed to bring up results on two characters on regular precision setting.

jjw24 avatar Aug 11 '21 10:08 jjw24

Hm, weird, I tried a fresh install of 1.8.1, seems notepad++ still show in the bottom (with regular on)

On fresh install, if you query 'notepad++' it will show somewhere on the list for sure, but you will never get it with '++' query, and consequently you cant as @skjerns mentions, train it with frequency to show up higher when query '++'

No, I tried with ++ not notepad++ 😄 But i use notepad++ portable so maybe different there.

pc223 avatar Aug 11 '21 10:08 pc223

Yes, I'm using the regularly installed version v7.9.5 64bit. Updated to Flow 1.8.2, problem still persists :-/

skjerns avatar Aug 11 '21 13:08 skjerns

I don't think training it helps, because the score bump is done after the result filtering.

taooceros avatar Aug 12 '21 01:08 taooceros

if '++' brings up notepad++, then training would help bump it up, unless i am not remembering the design right?

jjw24 avatar Aug 12 '21 03:08 jjw24

Yeah, but @skjerns cannot find notepad++ with ++. We can optimize it by let special character bumps score for acronym search, but not include it in score panelty.

taooceros avatar Aug 12 '21 15:08 taooceros

yeah think if it's purely special symbol characters or numerals only in the query, we can bump for acronym and not include in score penalty.

jjw24 avatar Aug 12 '21 22:08 jjw24

Agreed, ++ for notepad++ is a reasonable query, I think we should support this use case by default 👍

pc223 avatar Aug 13 '21 04:08 pc223

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

github-actions[bot] avatar Jul 13 '22 02:07 github-actions[bot]