Flow.Launcher icon indicating copy to clipboard operation
Flow.Launcher copied to clipboard

Improve Basic Preview Panel

Open onesounds opened this issue 9 months ago • 4 comments

What's the PR

  • The preview shows the file size and the dates it was created and modified.
  • This item can be turned on and off by the user. All three are turned on and off at once.
  • General > Show details in preview area (on/off). Default is off.

ETC

  • If we need more in the future, we may need to turn them on and off on a per-item basis.
    • Media Lengh...?
  • We might need a separate settings page for the preview area. (not now...)
  • Users may want to change the timeformat, but this is how we'll proceed for now.

Test Cases

  • It should be on and off depending on settings.
  • Items with no file size information(ex>folder) should not be visible at all.
  • Colors should display properly even if the theme changes.

Todo

  • [ ] Check ResultManager.cs logic
  • [ ] Can we add folder created/modifed date? (Folder size is not considered. This is usually computationally intensive.)

onesounds avatar Apr 30 '24 02:04 onesounds

@check-spelling-bot Report

:red_circle: Please review

See the :open_file_folder: files view, the :scroll:action log, or :memo: job summary for details.

:x: Errors Count
:x: forbidden-pattern 1
:warning: non-alpha-in-dictionary 11

See :x: Event descriptions for more information.

Forbidden patterns :no_good: (1)

In order to address this, you could change the content to not match the forbidden patterns (comments before forbidden patterns may help explain why they're forbidden), add patterns for acceptable instances, or adjust the forbidden patterns themselves.

These forbidden patterns matched content:

Reject duplicate words

\s([A-Z]{3,}|[A-Z][a-z]{2,}|[a-z]{3,})\s\g{-1}\s
If the flagged items are :exploding_head: false positives

If items relate to a ...

  • binary file (or some other file you wouldn't want to check at all).

    Please add a file path to the excludes.txt file matching the containing file.

    File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

    ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

  • well-formed pattern.

    If you can write a pattern that would match it, try adding it to the patterns.txt file.

    Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

    Note that patterns can't match multiline strings.

github-actions[bot] avatar Apr 30 '24 02:04 github-actions[bot]

IMO the implementation of preview panel should be moved to explorer plugin. it's all about files.

VictoriousRaptor avatar May 01 '24 03:05 VictoriousRaptor

I moved the new functionality into the Explorer plugin itself.

I have a few issues with the way the date is currently displayed:

  1. I think yy-M-dd date format is very confusing. It's 24-5-20 right now. I would strongly prefer yyyy-MM-dd (2024-05-20) or an option in the settings for the user to be able to customize it.
  2. Same with time. hh:mm displays time in 12-hour format, but it doesn't specify AM/PM. At the very least it should display AM/PM (add tt at the end), but there's a problem: with CultureInfo.CurrentCulture, it does translate the date, but in my CurrentCulture AM/PM doesn't exist, we use 24-hour clock, so I get an empty space where AM/PM should be if I add tt in the format.

Yusyuriv avatar May 20 '24 17:05 Yusyuriv

Let's add the Show Toggle option and DateTimeFormat in plugin setting.

onesounds avatar May 22 '24 19:05 onesounds

Time formats and date formats in Settings.cs probably need some adjustments.

Yusyuriv avatar May 24 '24 04:05 Yusyuriv

There's a separator color issue, which I'll fix in a separate PR. (Previously, I didn't want to add a style to the separator color, so I made it get the color from the already assigned separator. Changing to panels in this PR is causing this color to not be imported. Need to add a separate style).

onesounds avatar May 24 '24 23:05 onesounds