Flow.Launcher icon indicating copy to clipboard operation
Flow.Launcher copied to clipboard

BUG: Flow Launcher does not support symbolic links

Open Farravid opened this issue 1 year ago • 3 comments

Checks

  • [X] I have checked that this issue has not already been reported.

  • [X] I am using the latest version of Flow Launcher.

Problem Description

I'm trying to sym link the settings of Flow Launcher and I'm getting an error everytime I open it or save the settings. I'd like to be able to create a symlink to the different settings in order to build my dotfiles.

2024-02-25.txt

To Reproduce

  1. Create a symbolic link to the Settings.json
  2. Open Flow Launcher

Screenshots

image

Flow Launcher Version

1.17.2

Windows Build Number

10.0.22631.3155]

Error Log


Flow Launcher version: 1.17.2
OS Version: 22631.3155
IntPtr Length: 8
x64: True

Python Path: 
Node Path: 
Date: 02/25/2024 18:29:32
Exception:
System.IO.IOException: This application does not support the current operation on symbolic links.
   at System.IO.FileSystem.ReplaceFile(String sourceFullPath, String destFullPath, String destBackupFullPath, Boolean ignoreMetadataErrors)
   at Flow.Launcher.Infrastructure.Storage.JsonStorage`1.AtomicWriteSetting() in C:\projects\flow-launcher\Flow.Launcher.Infrastructure\Storage\JsonStorage.cs:line 209
   at Flow.Launcher.Infrastructure.Storage.JsonStorage`1.Save() in C:\projects\flow-launcher\Flow.Launcher.Infrastructure\Storage\JsonStorage.cs:line 189
   at Flow.Launcher.ViewModel.SettingWindowViewModel.Save() in C:\projects\flow-launcher\Flow.Launcher\ViewModel\SettingWindowViewModel.cs:line 149
   at Flow.Launcher.PublicAPIInstance.SaveAppAllSettings() in C:\projects\flow-launcher\Flow.Launcher\PublicAPIInstance.cs:line 86
   at Flow.Launcher.App.<OnStartupAsync>b__14_0() in C:\projects\flow-launcher\Flow.Launcher\App.xaml.cs:line 108
   at Flow.Launcher.Infrastructure.Stopwatch.NormalAsync(String message, Func`1 action) in C:\projects\flow-launcher\Flow.Launcher.Infrastructure\Stopwatch.cs:line 58
   at Flow.Launcher.App.OnStartupAsync(Object sender, StartupEventArgs e) in C:\projects\flow-launcher\Flow.Launcher\App.xaml.cs:line 51
   at System.Threading.Tasks.Task.<>c.<ThrowAsync>b__128_0(Object state)
   at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Int32 numArgs)
   at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Int32 numArgs, Delegate catchHandler)
[2024-02-25.txt](https://github.com/Flow-Launcher/Flow.Launcher/files/14397207/2024-02-25.txt)


Farravid avatar Feb 25 '24 17:02 Farravid

we use an atomic way to save files in order to prevent various reported setting lost. I assume that doesn't work with symlink, in which nothing we can do now.

Maybe we can use some more sophisticated database structure to store settings, but not in the current stage.

taooceros avatar Feb 26 '24 05:02 taooceros

Hmm okay, thanks for replying!

Farravid avatar Feb 26 '24 08:02 Farravid

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 60 days.\n\nAlternatively this issue can be kept open by adding one of the following labels:\nkeep-fresh

github-actions[bot] avatar Apr 27 '24 01:04 github-actions[bot]

This issue was closed because it has been stale for 7 days with no activity. If you feel this issue still needs attention please feel free to reopen.

github-actions[bot] avatar May 04 '24 01:05 github-actions[bot]