Flow.Launcher icon indicating copy to clipboard operation
Flow.Launcher copied to clipboard

BUG: About thumbnails

Open 1208nn opened this issue 1 year ago • 4 comments

Checks

  • [X] I have checked that this issue has not already been reported.

  • [X] I am using the latest version of Flow Launcher.

Problem Description

  • Flow fails to get thumbnails and crashes
  • Flow crashes when it was still starting but i try to use it

To Reproduce

I don't know the exactly conditions of triggering it, but I can provide some characteristics.

apologize for my poor English

  • when crashes, process still in taskmgr but do not show gui
  • if crash happens when gui still open (setting window), Microsoft windows tags flow's setting window as no response
  • when crashed, process shows in the taskmgr in the background process category and at the time I pressed alt+space, flowlauncher.exe moves to the applications category which means the gui window (search box) created, but i can't see it
  • once this happens, flow must be killed and start manually to work, but before a reboot, will still fails to get thumbnails and crashes frequently

  • sometimes windows file explorer's thumbnail function also crashed
  • maybe follow with windows updates installed and need to reboot
  • sometimes use sfc /scannow could find something wrong with the windows

sometimes when flow was still starting, I pressed alt+space and it will happens but in this occasions, once I kill and start manually, it works well and won't crashes frequently until a thumbnail error

Screenshots

below

Flow Launcher Version

at least from 1.9.0 to 1.17.1

Windows Build Number

at least from 10.1803 to 10.23H2

Error Log

----hide manually time---- - ERROR - ImageLoader.Load - Failed to get thumbnail for ----hide manually my flow dir----\FlowLauncher\app-1.17.1\Images\up.png on first try

---- added manually ---- this also has other pngs and more than 1 try

EXCEPTION OCCURS: System.Runtime.InteropServices.COMException (0x80004005): Error while extracting thumbnail for ----hide manually my flow dir----\FlowLauncher\app-1.17.1\Images\up.png
 ---> System.Runtime.InteropServices.COMException (0x8004B201): 0x8004B201
   at IntPtr Flow.Launcher.Infrastructure.Image.WindowsThumbnailProvider.GetHBitmap(string fileName, int width, int height, ThumbnailOptions options) in C:/projects/flow-launcher/Flow.Launcher.Infrastructure/Image/ThumbnailReader.cs:line 129
   at BitmapSource Flow.Launcher.Infrastructure.Image.WindowsThumbnailProvider.GetThumbnail(string fileName, int width, int height, ThumbnailOptions options) in C:/projects/flow-launcher/Flow.Launcher.Infrastructure/Image/ThumbnailReader.cs:line 120
   at ImageResult Flow.Launcher.Infrastructure.Image.ImageLoader.GetThumbnailResult(ref string path, bool loadFullImage) in C:/projects/flow-launcher/Flow.Launcher.Infrastructure/Image/ImageLoader.cs:line 247
   at async ValueTask<ImageResult> Flow.Launcher.Infrastructure.Image.ImageLoader.LoadInternalAsync(string path, bool loadFullImage) in C:/projects/flow-launcher/Flow.Launcher.Infrastructure/Image/ImageLoader.cs:line 169

1208nn avatar Feb 07 '24 12:02 1208nn

thumbnails not only don't show in the result, also not show in settings, but sometimes when it not show, flow won't crashes.

Screenshots

setting window - plugins image

search box image

image

theme switcher preview (background) image

store (maybe caused by network, suggest a loading icon to recognize) image

no response image

1208nn avatar Feb 07 '24 13:02 1208nn

Does it happens before?

taooceros avatar Feb 08 '24 14:02 taooceros

Yes

Flow Launcher Version

at least from 1.9.0 to 1.17.1

I started use Flow from 1.9.0.

Before I use Flow, I use Wox. It seldom crashes. I sometimes use PowerToys Run, It seldom crashes, too.

In the latest 1.17.1, sometimes the crash will directly cause the process killed, without the no response statues.

1208nn avatar Feb 09 '24 05:02 1208nn

Same here, with FlowLauncher v1.17.2 and Windows 11 23H2

09:57:53.2882+01:00 - ERROR - ImageLoader.Load - Failed to get thumbnail for C:\Users\user\AppData\Local\FlowLauncher\app-1.17.2\Plugins\Flow.Launcher.Plugin.WebSearch\Images\web_search.png on second try
EXCEPTION OCCURS: System.Runtime.InteropServices.COMException (0x80004005): Error while extracting thumbnail for C:\Users\user\AppData\Local\FlowLauncher\app-1.17.2\Plugins\Flow.Launcher.Plugin.WebSearch\Images\web_search.png
 ---> System.Runtime.InteropServices.COMException (0x8004B201): 0x8004B201
   at IntPtr Flow.Launcher.Infrastructure.Image.WindowsThumbnailProvider.GetHBitmap(string fileName, int width, int height, ThumbnailOptions options) in C:/projects/flow-launcher/Flow.Launcher.Infrastructure/Image/ThumbnailReader.cs:line 129
   at BitmapSource Flow.Launcher.Infrastructure.Image.WindowsThumbnailProvider.GetThumbnail(string fileName, int width, int height, ThumbnailOptions options) in C:/projects/flow-launcher/Flow.Launcher.Infrastructure/Image/ThumbnailReader.cs:line 120
   at ImageResult Flow.Launcher.Infrastructure.Image.ImageLoader.GetThumbnailResult(ref string path, bool loadFullImage) in C:/projects/flow-launcher/Flow.Launcher.Infrastructure/Image/ImageLoader.cs:line 247
   at async ValueTask<ImageResult> Flow.Launcher.Infrastructure.Image.ImageLoader.LoadInternalAsync(string path, bool loadFullImage) in C:/projects/flow-launcher/Flow.Launcher.Infrastructure/Image/ImageLoader.cs:line 169

mlazzarotto avatar Feb 16 '24 09:02 mlazzarotto

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 60 days.\n\nAlternatively this issue can be kept open by adding one of the following labels:\nkeep-fresh

github-actions[bot] avatar Apr 17 '24 01:04 github-actions[bot]

This issue was closed because it has been stale for 7 days with no activity. If you feel this issue still needs attention please feel free to reopen.

github-actions[bot] avatar Apr 25 '24 01:04 github-actions[bot]