Flow.Launcher icon indicating copy to clipboard operation
Flow.Launcher copied to clipboard

Support change log level in settings

Open rainyl opened this issue 2 years ago • 9 comments

Discussed in https://github.com/Flow-Launcher/Flow.Launcher/discussions/2313

Originally posted by rainyl August 30, 2023 I am one of the Flow plugin developers, I noticed that the default log level of Flow is INFO, I am wondering how to change the log level to DEBUG in Flow, thus I can debug my plugin more efficient using API.LogDebug() and needn't to worry bothering users because their default log level is INFO.

For now, I can't find some settings to change log level, also, if it is currently not supported, I think it will be nice if added.

Thanks.

rainyl avatar Aug 31 '23 14:08 rainyl

If you run flow in debug mode, the debug level will be changed to DEBUG instead of INFO. It shouldn't be a hard thing as you should already have the dotnet sdk installed. All you need is to clone flow and run it with whatever ide you used.

taooceros avatar Sep 07 '23 12:09 taooceros

thanks, but it will be more convenient if we can set it just in settings rather than run another debug version, hope it will be added in the future.

rainyl avatar Sep 08 '23 01:09 rainyl

thanks, but it will be more convenient if we can set it just in settings rather than run another debug version, hope it will be added in the future.

making sense.

taooceros avatar Sep 09 '23 00:09 taooceros

This issue is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 5 days.

github-actions[bot] avatar Oct 24 '23 01:10 github-actions[bot]

This issue is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 5 days.

github-actions[bot] avatar Dec 11 '23 01:12 github-actions[bot]

@taooceros is this still an issue we need to keep fresh?

deefrawley avatar May 17 '24 10:05 deefrawley

Well, fell free to close it if not planed.

rainyl avatar May 18 '24 01:05 rainyl

It's not that easy to change. Logger is initialized at the very beginning. Maybe we can set to debug for default, after loading settings than set it to user defined level?

VictoriousRaptor avatar May 19 '24 15:05 VictoriousRaptor

Is this a hard task??? It doesn't matter if it doesn't reflect in real time. I think we could just put "loglevel" in config and apply it after restart, or even set it directly in json without a config ui. Am I thinking wrong?

+)https://github.com/Flow-Launcher/Flow.Launcher/discussions/2313 jjw's comment confirms that the debug log itself is meaningless. It is more correct to provide logs to make it easier for plugin developers to work with.

onesounds avatar May 20 '24 07:05 onesounds

It's not that easy to change. Logger is initialized at the very beginning. Maybe we can set to debug for default, after loading settings than set it to user defined level?

Set it to 'Error' level as default, allow the change to 'Debug', request a restart of flow after the change if makes it simpler.

jjw24 avatar Jul 03 '24 13:07 jjw24