launch arguments not being correctly passed when using "Run As Administrator"

[iamsivil]

trafficstars

Describe the bug/issue When using "Run As Administrator" launch arguments (see Figure 1) from the shortcut being launched do not appear to be maintained. These same arguments appear to be correctly passed through when NOT using "Run As Administrator". More specifically this is at least the 'Target' field and potentially the 'Start in' field on the shortcut.

To Reproduce I used Discord to reproduce this via the default Discord shortcut available on the start menu.

Steps to reproduce the behavior:

1. Have Discord installed and confirm the shortcut in your start menu is similar to the one in Figure 1 (version/path may be different)
2. In Flow navigate to Discord then do "Launch As Administrator"
3. Note that the UAC prompt is missing the arguments from the shortcut (see Figure 2)
4. Close the UAC dialog and attempt to launch the shortcut as Administrator from the Windows Start menu
5. Note that the UAC prompt correctly has the arguments from the shortcut (see Figure 3)

Screenshots Figure 1:

Figure 2:

Figure 3:

Your System

Windows build number: Microsoft Windows [Version 10.0.19044.1586]
Windows language: EN-US
Flow Launcher version: 1.9.3

Flow Launcher Error Log No error appears to be actually logged but here is the log anyways:

2022-05-05.txt

[1234Brian]

👍

[github-actions[bot]]

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

[iamsivil]

bump this is definitely still occurring

[github-actions[bot]]

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

[1234Brian]

👍🌟

[nachmore]

I've root caused this to us not extracting arguments when a link resolves to an exe - essentially missing a call to ((IShellLinkW)link).GetArguments).

I'll look into getting a PR for this one over the next couple of days.

[jjw24]

Awesome, thank you @nachmore

[github-actions[bot]]

This issue is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 5 days.

[iamsivil]

bumping so it doesn't get auto closed due to stale

[github-actions[bot]]

This issue is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 5 days.

[github-actions[bot]]

This issue is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 5 days.

[VictoriousRaptor]

Fixed in 1.10.0