bitwise icon indicating copy to clipboard operation
bitwise copied to clipboard

added arithmetic shift operations

Open 0xflotus opened this issue 3 years ago • 3 comments

part 2 of fix #44

0xflotus avatar Oct 13 '20 11:10 0xflotus

Codecov Report

Merging #47 into master will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #47   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           43        45    +2     
  Lines          311       325   +14     
  Branches        49        49           
=========================================
+ Hits           311       325   +14     
Impacted Files Coverage Δ
source/bits/arithmetic-shift-left.ts 100.00% <100.00%> (ø)
source/bits/arithmetic-shift-right.ts 100.00% <100.00%> (ø)
source/bits/index.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 97ff2e6...5e8237a. Read the comment docs.

codecov-io avatar Oct 13 '20 11:10 codecov-io

oops, I swapped left shift with right shift. Fixed it a few minutes ago.

0xflotus avatar Oct 13 '20 21:10 0xflotus

@0xflotus I merged the circular shift one as it was obvious how it should behave on arbitrary lengths of bits (doesn’t modify length). However, I’m really not sure about this one and if it’s more reasonable to keep the length or to decrease/increase it by amount

FlorianWendelborn avatar Feb 18 '21 13:02 FlorianWendelborn