bitwise icon indicating copy to clipboard operation
bitwise copied to clipboard

Published 20 hours ago • verified publisher icon FlorianWendelborn

Extend Operation Functionality

Open 0xflotus opened this issue 4 years ago • 4 comments

Can you please implement bit shift operations like logical shift, arithmetic shift and cyclic shift ?

  • [ ] Logical Shift (#45 — currently stuck)
  • [ ] Arithmetic Shift (#47 — currently stuck)
  • [x] Cyclic Shift (#49)

0xflotus avatar Jan 28 '20 11:01 0xflotus

Sorry, don’t have time for this right now, if you (or anyone else) want(s) to pick this up feel free to send a PR.

FlorianWendelborn avatar Apr 12 '20 22:04 FlorianWendelborn

@0xflotus thanks for the PRs, I’m willing to get them merged soon. However, I left a couple questions on the individual pull requests

In general, this looks very mergeable already, pretty much only a few minor nitpicks open regarding public API.

FlorianWendelborn avatar Oct 13 '20 15:10 FlorianWendelborn

Are all commits fine?

0xflotus avatar Oct 26 '20 09:10 0xflotus

@0xflotus yes, I think so, I’m unfortunately just very busy right now. It’s still on my radar though 😞

FlorianWendelborn avatar Oct 27 '20 08:10 FlorianWendelborn