Floorp icon indicating copy to clipboard operation
Floorp copied to clipboard

Side Web Panel not Loading Icons Correctly.

Open Mibix opened this issue 1 year ago • 7 comments

Pre-Submission Checklist

  • [X] I have checked the existing/closed issues to ensure this issue has not already been reported.
  • [X] I am using the latest supported version of the browser.
  • [X] I have tried disabling all browser extensions/add-ons to rule out interference from these.
  • [X] I have tried clearing the browser cache and cookies.
  • [X] I have checked with a new profile and the issue still occurs.
  • [X] I have provided detailed step-by-step instructions on how to reproduce the issue.
  • [X] I have included relevant screenshots or console outputs.
  • [X] I have checked this problem is not occurring in the latest version of Firefox ESR.
  • [X] This issue is specific to this browser and does not occur in other browsers.

Bug Summary

Some sites don't load their icons properly and show up either blank or as just a globe in the side web panel. You can force them with custom CSS if you know the web address of the favicon.ico but its not easy to find. This is a lot less troublesome on Vivaldi. Homeassistant instances are one where it can't find it for example.

Reproduction Steps

  1. Add new web panel
  2. Add a site where the favicon.ico isn't in the root of the site.
  3. Watch the icon be missing

Expected Behavior

Should load the same icon that is displayed when the site is loaded in a tab.

Actual Behavior

Loads a default web icon or no icon at all

Screenshots

Screenshot 2024-06-12 033705

Browser Version

11.14.0 (64-bit)

Operating System

Win 11 Version 22H2 Build 22621.3737

Additional Context

No response

Mibix avatar Jun 12 '24 20:06 Mibix

this issue is from https://www.reddit.com/r/Floorp/s/IpDy6Y3NOn This is because Floorp uses external "icon provider" to get favicon. the way to fix is to allow customizing to get favicon from server directly with IP(incl.ipv6) pattern.

nyanrus avatar Jun 12 '24 22:06 nyanrus

this issue is from https://www.reddit.com/r/Floorp/s/IpDy6Y3NOn This is because Floorp uses external "icon provider" to get favicon. the way to fix is to allow customizing to get favicon from server directly with IP(incl.ipv6) pattern.

Yeah I got the workaround working but what is the advantage of having an external icon provider?

Mibix avatar Jun 12 '24 23:06 Mibix

It is useful to get icon without accessing to the server. Using external icon provider, Floorp do not need to get the html, no accessing to the server, no log to the server.

Some website seems to use svg with html link tag, not favicon.ico. And the external icon providers provide unified API to get these favicon. https://developers.google.com/search/docs/appearance/favicon-in-search

nyanrus avatar Jun 13 '24 00:06 nyanrus

Ideally it parses the website for the icon, but an alternative would be to be able to set a custom icon for websites. This would also solve for those local links or those that want to customise the icons.

deletedpenguin avatar Jun 16 '24 08:06 deletedpenguin

Ideally it parses the website for the icon, but an alternative would be to be able to set a custom icon for websites. This would also solve for those local links or those that want to customise the icons.

I'd really love that feature as I have a lot of custom/local webpages in that sidebar which often have the same or no favicon at all.

lufixSch avatar Jul 29 '24 16:07 lufixSch

I personally would love to see some sort of custom icon method as my telegram icon get's a white square on google icon provider, but under duckduckgo the web.whatsapp icon just disappears. Google: image DDG: image

nikolas-sturm avatar Aug 28 '24 08:08 nikolas-sturm

I personally would love to see some sort of custom icon method as my telegram icon get's a white square on google icon provider, but under duckduckgo the web.whatsapp icon just disappears. Google: image DDG: image

This seems to be a new problem, as it didn't used to do this.

deletedpenguin avatar Aug 28 '24 09:08 deletedpenguin