AddFiles with empty tags overrides d.custom1 with empty string

[bendardenne]

Type: Bug Report

Your Environment

• Version used: git bb553506a86225811a965563af99bf8e39cc433f

Summary

When triggering an addFiles request with empty "tags" in the body, the empty string is assigned as tag into d.custom1.

In server/models/ClientRequests there is a guard to only set custom1 if the tags are an non-empty array. However, earlier in the code, the tags are put through String.split() which returns an array containing the empty string if the source string is empty. So the guard fails (probably unintentionally).

Expected Behavior

d.custom1 should not change.

Context

I have a script that runs when torrents are added to rtorrent to automatically assign tags into custom1. This bug causes any tags set by my script to be overwritten with the empty string.