[Discussion] Project quality

[noraj]

Discussion

@jfurrow don't want more developers on the project because he see low quality commits from contributors BUT the actual state of the project is the following:

• no user documentation #385
• no developer documentation #385 #569
• no docker documentation #649
• no unit tests / anti-regression tests
• ~~no organization #672~~, only 1 dev
• no active development / low activity
• no feature like plugin API #647
• low quality lint rules #555
• lot of open issues (that are not moving)
• PR are merged a long time after they were made
• no versioning (only 1 release) #734
• changelog not updated

So if I was a JS developer I maybe wouldn't participate to this project.

Let's had some vital stuff like documentation, tests, organization, else the project will never be a true FOSS project but just a dead/low activity personal project.

[bbashy]

What exactly are you saying here? Bit confused on the past/present tense you're using.

[noraj]

@bbashy The whole description is using present tense except the following sentence that is using conditional tense:

So if I was a JS developer I maybe wouldn't participate to this project.

I can't make this post more clear as it is already summing up 2 or 3 previous issues about the project / organization.

[bbashy]

Maybe I was just reading it a bit wrong. Is this something they've said to you? I've replaced don't with doesn't and see with sees.

jfurrow doesn't want more developers on the project because he sees low quality commits from contributors, but the actual state of the project is the following:

[noraj]

From jfurrow on https://github.com/jfurrow/flood/issues/672#issuecomment-421603351

@noraj I'll just close this.

The quality of some of the contributions have been very low, so I don't want more people merging and accepting these contributions unless they are going to enforce a level of quality control.

That's not really he don't want more dev, but he want dev that proved they were doing and enforcing good quality but as he takes weeks or months to review and merge + all the not appealing stuff I said in this issue no one want to contribute and the project in going into a frozen area.

[jfurrow]

@noraj I can definitely understand your frustrations. My attention to Flood has slowed dramatically over the past year or two.

I'd like to clarify that I do want more contributors working on the project (developers, designers, whoever else makes sense). For this to be effective, I'll need some help ensuring incoming contributions meet or exceed a certain level of quality, and when they don't, somebody needs to either shepherd the PR to completion or close with good reason. I cannot do this alone — it's just not as fun as working on new features or initiatives that interest me.

That said, I need to be more proactive in reviewing contributions. I think you're right that moving to an organization might help achieve this, so I'll do that.

I don't agree with all of the things in your list but I'll save that discussion for somewhere more appropriate.

Is there anything actionable that can be taken from this issue, or should I close it?

[noraj]

You can close it or keep it as a roadmap.

[noraj]

I'd like to clarify that I do want more contributors working on the project (developers, designers, whoever else makes sense).

Impossible without #672.

Also people are already complaining about the project being dead (see https://github.com/jfurrow/flood/issues/758#issuecomment-457861534).

[GottZ]

no dev docs: well. doxygen could do that.

unit tests.. even tests in a headless chrome should be present and be executed for each commit and pull request.

org.. not really required but i agree it would make project management simpler. also would give us orgname.github.io as a sideeffect.

no plugin api.. plugins are hard. but i agree they would cause diversity.

low quality linting etc.. ye.

and no dead code detection.

dis is work. alot of work.

[noraj]

@GottZ

no dev docs: well. doxygen could do that.

see package.json, .jsdoc.json we are already "using" JSDoc as it is a javascript project.

[noraj]

I'm quitting this project as it is going nowhere for years. I'm using qbittorent webui. It's less beautiful but have better stability, some tests, documentation, is reliable, no bug, etc.

[ngseer]

@noraj thank you for your hard work!

Hope the project will continue, I really like it. I also would like to contribute in some way but I'm not goot with JS at all :(

[jfurrow]

@noraj Thank you for your contributions ❤

[jesec]

Many issues have been addressed in the latest version of Flood.

You may close the issue if it is no longer relevant.