flood icon indicating copy to clipboard operation
flood copied to clipboard

Feeds does not follow redirects

Open mirolm opened this issue 6 years ago • 3 comments

Summary

Recently the feed of HorribleSubs started to use https. When you open it from browser the http version redirects to https. If you have the http version added it does not follow redirects and just stops working. If you add again all your rules with the https version it works without issues.

Expected Behavior

If a http feed redirects to https flood should follow this redirect.

Current Behavior

Feeds which redirect from http to https stop to match rules.

Possible Solution

Fix the component to follow redirects.

Steps to Reproduce (for bugs)

  1. Add a feed http://horriblesubs.info/rss.php?res=1080
  2. Add matching rules for some torrents.
  3. It does not work.
  4. Add the same feed with https - https://horriblesubs.info/rss.php?res=1080
  5. Add same rules to consume the https feeds.
  6. All works fine.

Context

Horrible subs feeds got reconfigured to use CloudFlare and now they use https. It is good change but flood does not handle redirects in feeds very well. As a workaround i reconfigured my feeds to just point to the https version.

Your Environment

  • Version used:
    • v1.0.0
    • commit 1493f8f
  • Chromium 67.0.3396.87, NodeJS v10.4.1
  • Server (Debian Stretch 9.4 x64), Client (Fully updated Arch Linux x64)

mirolm avatar Jul 03 '18 08:07 mirolm

I've added an issue into the FeedSub package as that's what's being used to manage them.

https://github.com/fent/node-feedsub/issues/30

bbashy avatar Aug 01 '18 17:08 bbashy

That package has been updated now. Someone needs to pull in the new version of FeedSub.

bbashy avatar Aug 05 '18 14:08 bbashy

This will be fixed now in master.

bbashy avatar Aug 18 '18 09:08 bbashy