Flole

Results 270 comments of Flole

Convert GPL license headers to SPDX format throughout codebase

@copilot It is illegal to remove the copyright notice and copyrights holder name, you must not do that. You may only replace the full license text by using the license...

Convert GPL license headers to SPDX format throughout codebase

@copilot Sometimes multiple names are mentioned in new lines of the copyright notice. You now removed the lines with the other names.

Convert GPL license headers to SPDX format throughout codebase

@copilot In some cases only the name of the other copyright holders was written on a new line, no other text. Those are problematic

Convert GPL license headers to SPDX format throughout codebase

@copilot In src/imagecache.c is one of the cases where what I meant happened

Convert GPL license headers to SPDX format throughout codebase

@chewitt I think this one is done :)

Convert GPL license headers to SPDX format throughout codebase

@copilot Do what @chewitt commented

Convert GPL license headers to SPDX format throughout codebase

@copilot Do what chewitt asked

Allow default buffer size for i2c library to be overridden by define

Apparently I was the one who was supposed to be mentioned ;) I've merged the PR, thanks!

Allow default buffer size for i2c library to be overridden by define

I'm using VisualMicro as IDE, and that allows global defines using the -D parameter.

Allow default buffer size for i2c library to be overridden by define

It's just one example that I picked, I know there's a project to use make files for Arduino-Projects and there it works aswell. So it's rather a missing feature of...