Florent Galland

There might have very tiny differences in the way we merge the smtp-server options with the options in the mailin constructor. That might come from there!

Well done! The correct one should be `disableDNSValidation` with DNS upper cased.

Let's wait for the tests, afterwards I'll publish it to npm. https://github.com/Flolagale/mailin/commit/63598715bb33db8d1c5be5606f2ffa7a8510712e

Right. There is a simplesmtp option to [limit the size of the attachments](https://github.com/andris9/simplesmtp#usage) but it is informative only, meaning that a malicious smtp client could send the attachement anyway. So...

Mmm actually we might be able to check the size and refuse the message before receiving it, see [https://github.com/andris9/simplesmtp/blob/master/examples/size.js#L18](https://github.com/andris9/simplesmtp/blob/master/examples/size.js#L18). Let me investigate a bit.

When several attachements have the same fileName, generatedFileName will be different from fileName, in order to get a kind of 'unique' file name. Anyway, I am sorry but I am...

Ok, you made an interesting point. Using the contentId as the key is a good idea, but it introduces some breaking changes to the API. I will implement it but...

Sorry I have been very busy lately, I did not get the time to fix this. I think we will use the contentId as a key. I will keep you...

Thanks! Would it be possible that you merge your patch-2 and patch-3 branches into patch-1 on your side? This would allow to review this as a single pull request.

For the Bcc issue, I don't know what is going on, I have to investigate. Regarding the attachments question, the webhook payload is a **multipart form** with a mailinMsg fields...