phpcs-security-audit icon indicating copy to clipboard operation
phpcs-security-audit copied to clipboard
verified publisher icon FloeDesignTechnologies

BadFunctions/NoEvals: add unit tests + minor fix

Open jrfnl opened this issue 5 years ago • 1 comments

Related to #57, follow up on #70, this PR adds unit tests for the Security.BadFunctions.NoEvals sniff.

Commit Summary

BadFunctions/NoEvals: add unit tests

BadFunctions/NoEvals: error message precision

eval() is a language construct, not a function.

Ref: https://www.php.net/manual/en/function.eval.php

BadFunctions/NoEvals: remove redundant function call

$tokens is not used, so no need to declare it.

jrfnl avatar Mar 16 '20 05:03 jrfnl

Anything I can do to move this PR forward ?

jrfnl avatar Jun 18 '20 07:06 jrfnl