Flix

Results 39 comments of Flix

Thank you again! :D After trying to remember, I think I created this issue for the following reasons: - I just quickly added search parameters for every search type/variant mentioned...

Oh, I actually didn't intend to do something to the `SearchParameters` type, but to the sub-types like `NumberSearch`. So for each of them, depending on the spec, possible multiple values...

Hmm maybe not actually that great, as the expanded codes are only the value sets and not expandable codes I think. Unsure if it is more codes. Also the expanded...

Adjusted to the requested changes. I also found a few more little things that I missed, e.g. the `DataType::get_string` implementation for `Data` and such.

I can't really progress until https://github.com/tafia/calamine/pull/441#discussion_r1633001639 . Could you elaborate a bit how you imagine things to be?

You mean conversion implementations to/from chrono? Like time, chrono will probably also not be able to differentiate between "2024" and "2024-01-01", if it can even save just 2024. So it...

Yeah that makes sense. The date would "conflict" or rather confuse though, as it still has the time::Date variant. Do you think it is possible to actually make something conceptually...

I think I would like to change the auth callback a little bit: - Make it a Box instead of Arc - FnMut instead of Fn - Lock it for...

More orthogonal possibilities: - Make auth callback a trait and allow both structs and closures/functions. This allows easier state management for auth handling. - Pass reqwest client to auth callback?

Alright, I addressed all of the ideas from the previous two comments and revamped the authentication handling. It should now be way easier to implement custom auth logic and SMART...