ProcessWire-AIOM-All-In-One-Minify icon indicating copy to clipboard operation
ProcessWire-AIOM-All-In-One-Minify copied to clipboard

PHP 7.3 Compatibility

Open jaromic opened this issue 5 years ago • 3 comments

With PHP 7.3.0 (Windows), AllInOneMinify 3.2.3, ProcessWire 3.0.123, I get the following Continue Targeting Switch Warning (path parts snipped):

Warning:  "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? in \site\assets\cache\FileCompiler\site\modules\AllInOneMinify\lib\Less\Less.php on line 9387
Warning:  "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? in \site\assets\cache\FileCompiler\site\modules\AllInOneMinify\lib\Less\Less.php on line 9395
Warning:  "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? in \site\assets\cache\FileCompiler\site\modules\AllInOneMinify\lib\Less\Less.php on line 9400
Warning:  "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? in \site\assets\cache\FileCompiler\site\modules\AllInOneMinify\lib\Less\Less.php on line 9406
Warning:  "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? in \site\assets\cache\FileCompiler\site\modules\AllInOneMinify\lib\Less\Less.php on line 9416
Warning:  "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? in \site\assets\cache\FileCompiler\site\modules\AllInOneMinify\lib\Less\Less.php on line 9419
Warning:  "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? in \site\assets\cache\FileCompiler\site\modules\AllInOneMinify\lib\Less\Less.php on line 9439
Warning:  "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? in \site\assets\cache\FileCompiler\site\modules\AllInOneMinify\lib\Less\Less.php on line 9444
Warning:  "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? in \site\assets\cache\FileCompiler\site\modules\AllInOneMinify\lib\Less\Less.php on line 9465
Warning:  "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? in \site\assets\cache\FileCompiler\site\modules\AllInOneMinify\lib\Less\Less.php on line 9472

I have not tried the fork mentioned in #65 , maybe this has been fixed there too.

jaromic avatar Apr 22 '19 19:04 jaromic

This patch did it for me.

jaromic avatar Apr 22 '19 19:04 jaromic

I also fixed it in my fork

matjazpotocnik avatar Apr 23 '19 18:04 matjazpotocnik

I also fixed it in my fork

Thanks, Matjaž. For others reading this, Matjaž' fork is linked in #65, read more about it in the forums.

jaromic avatar Apr 23 '19 21:04 jaromic