django-fullurl icon indicating copy to clipboard operation
django-fullurl copied to clipboard

Use full url in celery jobs

Open artofhuman opened this issue 7 years ago • 3 comments

Hi, ✋. I have a feature request. It'll be nice to allow the use of this lib in email templates. For example in an email. As I can see lib use request to determine domain part in url, but in background jobs, we don`t have the request. What do u think if use setting (BASE_URL='https://mysite.com') for example? Or maybe now it possible use in emails templates?

artofhuman avatar Aug 16 '18 10:08 artofhuman

This package does do that for the moment. You could use an alternative, django-absoluteuri, which uses the sites framework to determine the base domain.

Flimm avatar Aug 17 '18 09:08 Flimm

Thanks for the answer. It`ll be nice if this package may use a different backend. (request, settings, sites framework). In my case sites framework not good solution, because it makes db unnecessary query. I created own implementation in the project used setting

artofhuman avatar Aug 19 '18 09:08 artofhuman

I'd also prefer to use this app, with an option to fall back onto the sites framework if the request is not available. Basically best of both worlds. Thanks for the great work.

lggwettmann avatar Apr 02 '19 13:04 lggwettmann