Redundant test dependencies in package.xml of flexbe_app

[Plumezz]

Hello, after building and testing this project with branch humble, I found something unexpected.

I noticed the package.xml file in the package flexbe_app contains the following content which means a format check.

    <test_depend>ament_copyright</test_depend>
    <test_depend>ament_flake8</test_depend>
    <test_depend>ament_pep257</test_depend>
    <test_depend>python3-pytest</test_depend>

    <test_depend>ament_lint_auto</test_depend>
    <test_depend>ament_lint_common</test_depend>

But there are no test section in CMakeLists.txt resulting in no testing programs to run actually.

So I think if we want the ament_lint tools to do a format check, maybe need add the testing section in the CMakeLists.txt like following:

if(BUILD_TESTING)
  find_package(ament_lint_auto REQUIRED)
  ament_lint_auto_find_test_dependencies()
endif()

After adding the content, amen_lint_tools like ament_copyright, ament_lint_cmake, ament_xmllint, can be executed correctly when I use colcon test command.

But there are some format errors after testing. Here is the result file:

flexbe_app.log 2:flake8 5:xmllint

If we do not need the ament_lint_tools, I think the test_depend might be a redundant dependency that could be removed to reduce the burden of project maintenance.

I would appreciate it if you could tell me how do you think of this?

Thanks!