Kohei Takahashi
Kohei Takahashi
> > This PR improves DXF import performance; in my case it improves 5% of execution time (sorry I cannot provide dxf data due to confidential project). > > The...
I checked upward call graph ``` - Import::ImpExpDxfRead::OnReadLine(Base::Vector3 const&, Base::Vector3 const&, bool) - Import::ImpExpDxfRead::DrawingEntityCollector::AddObject(TopoDS_Shape const&, char const*) - App::Document::addObject(char const*, char const*, bool, char const*, bool) - Base::Type::createInstance() - Part::Feature::create()...
umm... I don't know why pre-commit.ci failed. My local pre-commit hook passed.
I add one more patch to reduce repeating same translation with string literal.
Sorry, what should I do? This PR is ready for review.
OK, I realized the codes came from https://cxx.sourceforge.net/ . So I will contact to upstream project maintainer.
> @Flast can you link to the upstream ticket when you get a chance ? Sorry, I still haven't created. I'll post the link when I opened. > What's the...