sodium-extra icon indicating copy to clipboard operation
sodium-extra copied to clipboard

[Feature Request] Smooth Lighting Level

Open Manamongods opened this issue 4 years ago • 2 comments

100% smooth lighting is hard on my eyes, and the "Smooth Lighting Level" setting in optifine is really nice, and I'm missing it with sodium.

Manamongods avatar Jan 06 '22 20:01 Manamongods

This is a vanilla feature, there isn't a difference between Minimum and Maximum at least in Sodium, so it's just been a single toggle under Quality > Smooth Lighting.

FlashyReese avatar Aug 07 '22 12:08 FlashyReese

From minecraft's wiki smooth lighting Minimum is just "an older version of the engine". I'm requesting an equivalent to optifine's "Smooth Lighting Level" slider, where you can choose whatever ambient occlusion darkness you want (the name of the slider is not very accurate).

For some examples, smooth lighting Maximum with 0% Smooth Lighting Level: Smooth lighting maximum 0% level

Smooth lighting Maximum with 100% Smooth Lighting Level: Smooth lighting maximum 100% level

Smooth lighting Off: Smooth lighting off

The slider in question: 2022-08-07_15 22 58

Manamongods avatar Aug 07 '22 13:08 Manamongods

Is this still planned?

RaptaG avatar Jan 02 '23 17:01 RaptaG

Likely not, the way sodium does smooth lighting is quite different.

FlashyReese avatar Jan 02 '23 17:01 FlashyReese

1.19.3 has also dropped the minimium smooth lighting system entirely as it was pointless to have and didn't actually function anymore as intended,

and instead they have chosen to convert it into a boolean instead where disabled means no smooth lighting and enabled means maxmium.

Kichura avatar Jan 02 '23 20:01 Kichura

Likely not, the way sodium does smooth lighting is quite different.

How so? Even though it's different surely it's still possible to do this though?

1.19.3 has also dropped the minimium smooth lighting system entirely as it was pointless to have and didn't actually function anymore as intended,

and instead they have chosen to convert it into a boolean instead where disabled means no smooth lighting and enabled means maxmium.

But this feature request is about ambient occlusion darkness, nothing to do with the difference between minimum/maximum smooth lighting?

Manamongods avatar Jan 02 '23 20:01 Manamongods