Alexander Grund

Results 882 comments of Alexander Grund

I find the description hard to understand. As of the commit: > ``` > cache-hit: > description: 'A boolean value to indicate an exact match was found for the primary...

Yes it seems to be that recently the windows images (I noticed it on windows-2019) include `StrawberryPerl` installed in `C:/Strawberry` This seems to be a [Perl distribution](https://strawberryperl.com/) However it contains...

Together with my Boost colleague Peter Dimov we figured out what is going on: CMake was updated to 3.25 which includes a change to find `*.a` files when configuring for...

To be fair: Perl needs a working compile environment to fully function, hence StrawberryPerl has a good reason to bundle a toolchain which is accessible when Perl is accessible (which...

> Perl does not need a working compile environment to fully function -- perl.exe is needed to fully function -- but it may be needed internally by module building routines...

> The actual indicator for whether two libraries are compatible is not GNU vs MSVC, but "what CRT is being used". [...] > The filename suffix is a poor substitute...

> Perhaps, but there is a strong argument that Strawberry Perl's pkg-config should not be in PATH by default on GHA images, because that implies that everyone who can detect...

I have no issue with that. So permission from me.

I'm seeing the same issue: `error: can't copy 'deepspeed/accelerator': doesn't exist or not a regular file` And indeed: This is a symlink after https://github.com/microsoft/DeepSpeed/pull/2560 got merged: https://github.com/microsoft/DeepSpeed/blob/master/deepspeed/accelerator So it doesn't...

I found the related bug #1909 and the solution there: https://github.com/microsoft/DeepSpeed/issues/1909#issuecomment-1225113348 Basically: ``` rm deepspeed/ops/{csrc,op_builder} rm deepspeed/accelerator cp -R csrc op_builder deepspeed/ops/ cp -R accelerator deepspeed/ ``` And all works...