feat: edit versioned change request
Thanks for submitting a PR! Please check the boxes below:
- [ ] I have added information to
docs/if required so people know about the feature! - [x] I have filled in the "Changes" section below?
- [x] I have filled in the "How did you test this code" section below?
- [x] I have used a Conventional Commit title for this Pull Request
Changes
Allows editing a versioned change request
- Opens up the edit feature modal with the changesets applied
- Corresponding changes are then converted back to changesets and updated with the change request
How did you test
https://github.com/user-attachments/assets/cbbda60a-903c-49bf-80a9-c00a23309377
this code?
Edit a change request in a versioned environment
The latest updates on your projects. Learn more about Vercel for GitHub.
| Project | Deployment | Review | Updated (UTC) |
|---|---|---|---|
| flagsmith-frontend-preview | Preview, Comment | Dec 16, 2025 1:34pm | |
| flagsmith-frontend-staging | Preview, Comment | Dec 16, 2025 1:34pm |
Docker builds report
| Image | Build Status | Security report |
|---|---|---|
ghcr.io/flagsmith/flagsmith-api-test:pr-6368 |
Finished :white_check_mark: | Skipped |
ghcr.io/flagsmith/flagsmith-e2e:pr-6368 |
Finished :white_check_mark: | Skipped |
ghcr.io/flagsmith/flagsmith-api:pr-6368 |
Finished :white_check_mark: | Results :white_check_mark: |
ghcr.io/flagsmith/flagsmith:pr-6368 |
Finished :white_check_mark: | Results :white_check_mark: |
ghcr.io/flagsmith/flagsmith-private-cloud:pr-6368 |
Finished :white_check_mark: | Results :white_check_mark: |
ghcr.io/flagsmith/flagsmith-frontend:pr-6368 |
Finished :white_check_mark: | Results :white_check_mark: |
My understanding of the requirements, written in test scenarios. @kyle-ssg is this your understanding of the behaviour? Anything else that we should be testing?
Non-scheduled CRs
- User can edit unpublished CRs they created
- User cannot edit unpublished CRs created by another user
- User cannot edit published CRs
Scheduled CRs
- User can edit unpublished scheduled CRs that they created
- User cannot edit unpublished scheduled CRs created by another user
- User cannot edit published scheduled CRs
My understanding of the requirements, written in test scenarios. @kyle-ssg is this your understanding of the behaviour? Anything else that we should be testing?
@matthewelwell The exception to that at the moment is anyone can edit a change request if they have the ability to create one. I can see a use case for this tbh, if someone is away we should let someone with appropriate permissions to do this.
@matthewelwell The exception to that at the moment is anyone can edit a change request if they have the ability to create one. I can see a use case for this tbh, if someone is away we should let someone with appropriate permissions to do this.
My concern with that is that we don't have any indication when a change request has been edited. If we're not going to add that (which is probably the correct approach for now), I would rather restrict it to the author, or environment admins for now.
At the moment, it's only the author that can delete a change request for example - I think we should add environment admins to this list, but I don't think anyone should be able to edit or delete a CR.
I've aligned the BE with my expectations in a PR here.
I've aligned the BE with my expectations in a PR here.
Ok yep, I've updated the FE to do this too.
Testing scenarios look valid