Flagsmith
feat: Add tag based permissions
Thanks for submitting a PR! Please check the boxes below:
- [x] I have added information to
docs/if required so people know about the feature! - [x] I have filled in the "Changes" section below?
- [x] I have filled in the "How did you test this code" section below?
- [x] I have used a Conventional Commit title for this Pull Request
Changes
Supersedes https://github.com/Flagsmith/flagsmith/pull/4250
When setting project and environment level permissions, users will now be able to enable and specify tags that the permissions apply to. Specifying tags will only apply to certain permissions (see docs)
How did you test this code?
I'm not able to until https://github.com/Flagsmith/flagsmith/issues/4640 is sorted
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| docs | ⬜️ Ignored (Inspect) | Visit Preview | Nov 13, 2024 1:03pm | |
| flagsmith-frontend-preview | ⬜️ Ignored (Inspect) | Visit Preview | Nov 13, 2024 1:03pm | |
| flagsmith-frontend-staging | ⬜️ Ignored (Inspect) | Visit Preview | Nov 13, 2024 1:03pm |
![vercel[bot] avatar](https://avatars.githubusercontent.com/in/8329?v=4 "Published by a pub.dev verified publisher"){kind=small}
Docker builds report
| Image | Build Status | Security report |
|---|---|---|
ghcr.io/flagsmith/flagsmith-e2e:pr-4643 |
Finished :white_check_mark: | Skipped |
ghcr.io/flagsmith/flagsmith-api-test:pr-4643 |
Finished :white_check_mark: | Skipped |
ghcr.io/flagsmith/flagsmith-api:pr-4643 |
Finished :white_check_mark: | Results :white_check_mark: |
ghcr.io/flagsmith/flagsmith:pr-4643 |
Finished :white_check_mark: | Results :white_check_mark: |
ghcr.io/flagsmith/flagsmith-private-cloud:pr-4643 |
Finished :white_check_mark: | Results :white_check_mark: |
ghcr.io/flagsmith/flagsmith-frontend:pr-4643 |
Finished :white_check_mark: | Results :white_check_mark: |
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
I don't understand how this is supposed to be used based on the docs description.
From what I understand, this functionality allows defining feature-level permissions so that only specific users can modify certain sensitive features. Happy to collaborate on these docs but I'd like to sync and understand how this functionality actually works first.
I don't understand how this is supposed to be used based on the docs description.
From what I understand, this functionality allows defining feature-level permissions so that only specific users can modify certain sensitive features. Happy to collaborate on these docs but I'd like to sync and understand how this functionality actually works first.
It's quite hard to describe but it does work as updated in the docs.
If permissions are tagged, the following permissions will only be granted on features with matching tags:
- Create feature, Update Feature, Segment Overrides, and Change Requests
If a user has admin permissions from another role or group it'll grant the user the missing permissions.
@gagantrivedi cc just to confirm, were the missing permissions added? This used to be just update feature and segment override
@gagantrivedi cc just to confirm, were the missing permissions added? This used to be just update feature and segment override
No, they are not added yet
Flagsmith feature linked: tag_based_permissions
Default Values:
| Environment | Enabled | Value | Last Updated (UTC) |
|---|---|---|---|
| Production | ❌ Disabled | 2024-09-18 15:13:59 | |
| Staging | ✅ Enabled | 2024-09-18 15:18:34 | |
| Demo | ❌ Disabled | 2024-09-18 15:13:59 | |
| Self hosted defaults | ❌ Disabled | 2024-09-18 15:13:59 |
![flagsmith[bot] avatar](https://avatars.githubusercontent.com/in/811209?v=4 "Published by a pub.dev verified publisher"){kind=small}
Flagsmith Feature tag_based_permissions has been updated:
Segment flagsmith_team values:
| Environment | Enabled | Value | Last Updated (UTC) |
|---|---|---|---|
| Demo | ✅ Enabled | 2024-10-30 19:17:41 |
Flagsmith Feature tag_based_permissions has been updated:
Segment flagsmith_team values:
| Environment | Enabled | Value | Last Updated (UTC) |
|---|---|---|---|
| Production | ✅ Enabled | 2024-10-30 19:20:04 |
Flagsmith Feature tag_based_permissions has been updated:
| Environment | Enabled | Value | Last Updated (UTC) |
|---|---|---|---|
| Demo | ✅ Enabled | 2024-12-04 14:06:51 |
Flagsmith Feature tag_based_permissions has been updated:
| Environment | Enabled | Value | Last Updated (UTC) |
|---|---|---|---|
| Production | ✅ Enabled | 2024-12-04 14:07:01 |
Flagsmith Feature tag_based_permissions has been updated:
Segment qbiq values:
| Environment | Enabled | Value | Last Updated (UTC) |
|---|---|---|---|
| Production | ✅ Enabled | 2024-12-05 16:04:05 |