flagsmith icon indicating copy to clipboard operation
flagsmith copied to clipboard

fix: update change request after create

Open kyle-ssg opened this issue 1 year ago • 3 comments

Thanks for submitting a PR! Please check the boxes below:

  • [x] I have added information to docs/ if required so people know about the feature!
  • [x] I have filled in the "Changes" section below?
  • [x] I have filled in the "How did you test this code" section below?
  • [x] I have used a Conventional Commit title for this Pull Request

Changes

The frontend was unnecessarily updating change requests after creation, this was only needed for MV features. In addition the payload was also incorrect as it didn't include the ids of changesets

kyle-ssg avatar Aug 28 '24 16:08 kyle-ssg

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 28, 2024 4:58pm
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 28, 2024 4:58pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Aug 28, 2024 4:58pm

vercel[bot] avatar Aug 28 '24 16:08 vercel[bot]

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-4551 Finished :white_check_mark: Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-4551 Finished :white_check_mark: Skipped
ghcr.io/flagsmith/flagsmith-api:pr-4551 Finished :white_check_mark: Results :white_check_mark:
ghcr.io/flagsmith/flagsmith:pr-4551 Finished :white_check_mark: Results :white_check_mark:
ghcr.io/flagsmith/flagsmith-private-cloud:pr-4551 Finished :white_check_mark: Results :white_check_mark:
ghcr.io/flagsmith/flagsmith-frontend:pr-4551 Finished :white_check_mark: Results :white_check_mark:

github-actions[bot] avatar Aug 28 '24 16:08 github-actions[bot]

Uffizzi Preview deployment-55657 was deleted.

github-actions[bot] avatar Aug 28 '24 17:08 github-actions[bot]

Fixes #4536

matthewelwell avatar Sep 04 '24 15:09 matthewelwell

In testing this, I've created #4588 but I think it's unrelated to this issue as I can reproduce it in current production when change requests and versioning is enabled.

matthewelwell avatar Sep 04 '24 15:09 matthewelwell