flagsmith icon indicating copy to clipboard operation
flagsmith copied to clipboard

fix: Tag Based permissions only validate some views

Open novakzaballa opened this issue 1 year ago • 4 comments

Thanks for submitting a PR! Please check the boxes below:

  • [x] I have added information to docs/ if required so people know about the feature!
  • [x] I have filled in the "Changes" section below?
  • [x] I have filled in the "How did you test this code" section below?
  • [x] I have used a Conventional Commit title for this Pull Request

Changes

Solve https://github.com/Flagsmith/flagsmith/issues/4287

How did you test this code?

Unit test added in the RBAC PR: https://github.com/Flagsmith/flagsmith-rbac/pull/26

novakzaballa avatar Aug 20 '24 16:08 novakzaballa

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Oct 21, 2024 8:40am
flagsmith-frontend-preview ⬜️ Ignored (Inspect) Visit Preview Oct 21, 2024 8:40am
flagsmith-frontend-staging ⬜️ Ignored (Inspect) Visit Preview Oct 21, 2024 8:40am

vercel[bot] avatar Aug 20 '24 16:08 vercel[bot]

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-4523 Finished :white_check_mark: Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-4523 Finished :white_check_mark: Skipped
ghcr.io/flagsmith/flagsmith-frontend:pr-4523 Finished :white_check_mark: Results :white_check_mark:
ghcr.io/flagsmith/flagsmith-api:pr-4523 Finished :white_check_mark: Results :white_check_mark:
ghcr.io/flagsmith/flagsmith:pr-4523 Finished :white_check_mark: Results :white_check_mark:
ghcr.io/flagsmith/flagsmith-private-cloud:pr-4523 Finished :white_check_mark: Results :white_check_mark:

github-actions[bot] avatar Aug 20 '24 16:08 github-actions[bot]

Uffizzi Preview deployment-57454 was deleted.

github-actions[bot] avatar Aug 20 '24 16:08 github-actions[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.21%. Comparing base (1ffef49) to head (09a457a). Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4523      +/-   ##
==========================================
- Coverage   97.22%   97.21%   -0.01%     
==========================================
  Files        1172     1172              
  Lines       40516    40535      +19     
==========================================
+ Hits        39390    39408      +18     
- Misses       1126     1127       +1     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Aug 20 '24 17:08 codecov[bot]