flagsmith icon indicating copy to clipboard operation
flagsmith copied to clipboard

feat: Move history

Open kyle-ssg opened this issue 1 year ago • 5 comments

Thanks for submitting a PR! Please check the boxes below:

  • [x] I have added information to docs/ if required so people know about the feature!
  • [x] I have filled in the "Changes" section below?
  • [x] I have filled in the "How did you test this code" section below?
  • [x] I have used a Conventional Commit title for this Pull Request

Changes

Moves the feature history page to within the feature modal

image

How did you test this code?

E2E tests need to be changed however no functionality has changed except removing the feature select.

kyle-ssg avatar Aug 14 '24 18:08 kyle-ssg

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 21, 2024 10:34am
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 21, 2024 10:34am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Aug 21, 2024 10:34am

vercel[bot] avatar Aug 14 '24 18:08 vercel[bot]

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-4499 Finished :white_check_mark: Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-4499 Finished :white_check_mark: Skipped
ghcr.io/flagsmith/flagsmith-api:pr-4499 Finished :white_check_mark: Results :white_check_mark:
ghcr.io/flagsmith/flagsmith-private-cloud:pr-4499 Finished :white_check_mark: Results :white_check_mark:
ghcr.io/flagsmith/flagsmith:pr-4499 Finished :white_check_mark: Results :white_check_mark:
ghcr.io/flagsmith/flagsmith-frontend:pr-4499 Finished :white_check_mark: Results :white_check_mark:

github-actions[bot] avatar Aug 14 '24 18:08 github-actions[bot]

Uffizzi Preview deployment-55269 was deleted.

github-actions[bot] avatar Aug 14 '24 18:08 github-actions[bot]

Some feedback:

  • The contents of the History tab can expand beyond what I'm allowed to scroll to
  • The contents of each entry's Quick Compare has too much whitespace for simple changes like turning a flag on/off
  • The "View History" option in the Features list links to the original History page, which is now a 404
  • The details view for each history entry looks orphaned, like it doesn't belong to any sidebar category (Features/Scheduling/Change Requests/etc). I wonder if there's a good way to permalink history entry details inside the modal as well, or if it would make sense to hide the sidebar in cases like these where it doesn't make sense. For example, viewing a single commit in GitHub doesn't feel out of place and has all sorts of links to browse to related items (branch, pull request, commit's files etc): https://github.com/Flagsmith/flagsmith/commit/f9cc1b0f1ca81182377efa5a755bc18d6087a595

https://github.com/user-attachments/assets/9737c8ff-096c-4d44-a02d-a32aa2323fb6

rolodato avatar Aug 14 '24 20:08 rolodato

  • The contents of the History tab can expand beyond what I'm allowed to scroll to

Fixed

  • The contents of each entry's Quick Compare has too much whitespace for simple changes like turning a flag on/off

Fixed

  • The "View History" option in the Features list links to the original History page, which is now a 404

Adjusted to link to tab within modal

  • The details view for each history entry looks orphaned, like it doesn't belong to any sidebar category

Added breadcrumb to feature

kyle-ssg avatar Aug 21 '24 10:08 kyle-ssg

@rolodato final review ? 🙏

kyle-ssg avatar Sep 10 '24 10:09 kyle-ssg