flagsmith icon indicating copy to clipboard operation
flagsmith copied to clipboard

feat: Manage user's groups

Open kyle-ssg opened this issue 1 year ago • 7 comments

Thanks for submitting a PR! Please check the boxes below:

  • [x] I have run pre-commit to check linting
  • [x] I have added information to docs/ if required so people know about the feature!
  • [x] I have filled in the "Changes" section below?
  • [x] I have filled in the "How did you test this code" section below?
  • [x] I have used a Conventional Commit title for this Pull Request

Changes

Todo: the API needs to return group_admin in /organisations/:id/groups for this to function correctly

image

How did you test this code?

Viewed / adjusted user permissions

kyle-ssg avatar Jul 09 '24 09:07 kyle-ssg

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 5, 2024 0:08am
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 5, 2024 0:08am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Nov 5, 2024 0:08am

vercel[bot] avatar Jul 09 '24 09:07 vercel[bot]

flagsmith-private-cloud image build and security scan finished :sparkles:

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-private-cloud:pr-4312 Finished :white_check_mark: Results :white_check_mark:

github-actions[bot] avatar Jul 09 '24 09:07 github-actions[bot]

flagsmith image build and security scan finished :sparkles:

Image Build Status Security report
ghcr.io/flagsmith/flagsmith:pr-4312 Finished :white_check_mark: Results :white_check_mark:

github-actions[bot] avatar Jul 09 '24 09:07 github-actions[bot]

flagsmith-e2e image build finished :sparkles:

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-e2e:pr-4312 Finished :white_check_mark: Skipped

github-actions[bot] avatar Jul 09 '24 09:07 github-actions[bot]

flagsmith-frontend image build and security scan finished :sparkles:

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-frontend:pr-4312 Finished :white_check_mark: Results :white_check_mark:

github-actions[bot] avatar Jul 09 '24 09:07 github-actions[bot]

flagsmith-api image build and security scan finished :sparkles:

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api:pr-4312 Finished :white_check_mark: Results :white_check_mark:

github-actions[bot] avatar Jul 09 '24 09:07 github-actions[bot]

Uffizzi Preview deployment-57024 was deleted.

github-actions[bot] avatar Jul 09 '24 09:07 github-actions[bot]

@kyle-ssg group_admin has now been added to the user objects in the response to the GET /organisations/:id/groups/ endpoint. This has been deployed to staging so I think you can test this using the staging preview?

matthewelwell avatar Oct 30 '24 09:10 matthewelwell

@kyle-ssg this is a great addition, and seems to work well. The only criticism I would have is that it's very hidden - to get there, you have to click on 'Edit Permissions' which seems a bit odd. I'm not sure what the solution is here to be honest, maybe we can simply just change it to 'Manage user' ?

matthewelwell avatar Oct 30 '24 13:10 matthewelwell

Also, I'd argue that it's something that might be useful for admins now too - groups aren't only used for permissions - you can assign features and change requests to them, for example.

matthewelwell avatar Oct 30 '24 13:10 matthewelwell

Screenshot 2024-10-30 at 13 45 54

matthewelwell avatar Oct 30 '24 13:10 matthewelwell

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api:pr-4312 Finished :white_check_mark: Results :white_check_mark:
ghcr.io/flagsmith/flagsmith-private-cloud:pr-4312 Finished :white_check_mark: Results :white_check_mark:
ghcr.io/flagsmith/flagsmith-api-test:pr-4312 Finished :white_check_mark: Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-4312 Finished :white_check_mark: Skipped
ghcr.io/flagsmith/flagsmith-api:pr-4312 Finished :white_check_mark: Results :white_check_mark:
ghcr.io/flagsmith/flagsmith-private-cloud:pr-4312 Finished :white_check_mark: Results :white_check_mark:
ghcr.io/flagsmith/flagsmith:pr-4312 Finished :white_check_mark: Results :white_check_mark:
ghcr.io/flagsmith/flagsmith-private-cloud:pr-4312 Finished :white_check_mark: Results :white_check_mark:
ghcr.io/flagsmith/flagsmith:pr-4312 Finished :white_check_mark: Results :white_check_mark:
ghcr.io/flagsmith/flagsmith-frontend:pr-4312 Finished :white_check_mark: Results :white_check_mark:
ghcr.io/flagsmith/flagsmith-frontend:pr-4312 Finished :white_check_mark: Results :white_check_mark:
ghcr.io/flagsmith/flagsmith-frontend:pr-4312 Finished :white_check_mark: Results :white_check_mark:

github-actions[bot] avatar Oct 30 '24 13:10 github-actions[bot]