flagsmith icon indicating copy to clipboard operation
flagsmith copied to clipboard

docs: Add .Net caching to docs

Open novakzaballa opened this issue 1 year ago • 3 comments

Thanks for submitting a PR! Please check the boxes below:

  • [X] I have run pre-commit to check linting
  • [X] I have added information to docs/ if required so people know about the feature!
  • [X] I have filled in the "Changes" section below?
  • [X] I have filled in the "How did you test this code" section below?
  • [X] I have used a Conventional Commit title for this Pull Request

Changes

Add content about .Net caching to docs

How did you test this code?

Tested locally running docusaurus

novakzaballa avatar Apr 24 '24 21:04 novakzaballa

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 25, 2024 10:04am
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 25, 2024 10:04am
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 25, 2024 10:04am

vercel[bot] avatar Apr 24 '24 21:04 vercel[bot]

I actually don't think the .NET caching implementation is usable in it's current state since it doesn't implement any method for maintaining the size. This will likely cause a memory leak in any of our customer's applications that utilise the caching and have a large number of identities. See issue here.

matthewelwell avatar Apr 25 '24 08:04 matthewelwell

I agree, we also should allow the user to set the TTL.

novakzaballa avatar Apr 29 '24 20:04 novakzaballa

As per the conversation, this docs PR will be closed until the feature is complete.

novakzaballa avatar May 13 '24 20:05 novakzaballa