flagsmith icon indicating copy to clipboard operation
flagsmith copied to clipboard

feat: versioned segment override change request

Open kyle-ssg opened this issue 1 year ago • 6 comments
trafficstars

Thanks for submitting a PR! Please check the boxes below:

  • [x] I have run pre-commit to check linting
  • [x] I have added information to docs/ if required so people know about the feature!
  • [x] I have filled in the "Changes" section below?
  • [x] I have filled in the "How did you test this code" section below?
  • [x] I have used a Conventional Commit title for this Pull Request

Changes

  • Environments with versioning + Change Requests enabled will now have the ability to create a change request for segment overrides image

  • Change requests now diff all of the feature states in comparison to live, irrespective of if versioning is enabled.

Much like versioning this will tell you changed, created and unchanged values

image

image

image

  • The create feature modal toast will now differentiate when a change request was created vs editing a feature. Creating a change request will close the create feature modal

  • Removed a confusing unused field "hide_from_client" from feature states

  • Note: versioned change requests cannot be edited due to the limited use case and complexity of updating a versions feature states in a change request.

How did you test this code?

  • Created, edited and removed segment overrides in a change request on an environment with versioning

kyle-ssg avatar Apr 17 '24 16:04 kyle-ssg

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 8, 2024 1:07pm
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 8, 2024 1:07pm
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 8, 2024 1:07pm

vercel[bot] avatar Apr 17 '24 16:04 vercel[bot]

Uffizzi Preview deployment-50354 was deleted.

github-actions[bot] avatar Apr 17 '24 16:04 github-actions[bot]

@kyle-ssg I've just noticed that the change request view doesn't actually show which segment a feature is being overridden by?

image

matthewelwell avatar May 01 '24 10:05 matthewelwell

Also, is there anything we can do to improve the view when you remove a segment override? I'm just seeing this

image

matthewelwell avatar May 01 '24 10:05 matthewelwell

@matthewelwell both issues should be resolved now

kyle-ssg avatar May 01 '24 15:05 kyle-ssg

@kyle-ssg when you create a CR with more than one segment override, the priority values don't seem right.

image

matthewelwell avatar May 02 '24 09:05 matthewelwell

@kyle-ssg I can't create any change requests now with segment overrides following the latest change:

image

matthewelwell avatar May 07 '24 10:05 matthewelwell

Related #1204

kyle-ssg avatar May 15 '24 12:05 kyle-ssg

@kyle-ssg Did we decide to explicitly exclude scheduling changes on segment overrides on environments without change requests enabled?

Editing a feature's state without change requests enabled let you schedule changes:

image

In comparison, editing segment overrides without change requests only let you make an immediate update:

image

rolodato avatar Aug 13 '24 11:08 rolodato