flagsmith
flagsmith copied to clipboard
feat: versioned segment override change request
Thanks for submitting a PR! Please check the boxes below:
- [x] I have run
pre-committo check linting - [x] I have added information to
docs/if required so people know about the feature! - [x] I have filled in the "Changes" section below?
- [x] I have filled in the "How did you test this code" section below?
- [x] I have used a Conventional Commit title for this Pull Request
Changes
-
Environments with versioning + Change Requests enabled will now have the ability to create a change request for segment overrides
-
Change requests now diff all of the feature states in comparison to live, irrespective of if versioning is enabled.
Much like versioning this will tell you changed, created and unchanged values
-
The create feature modal toast will now differentiate when a change request was created vs editing a feature. Creating a change request will close the create feature modal
-
Removed a confusing unused field "hide_from_client" from feature states
-
Note: versioned change requests cannot be edited due to the limited use case and complexity of updating a versions feature states in a change request.
How did you test this code?
- Created, edited and removed segment overrides in a change request on an environment with versioning
The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| docs | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | May 8, 2024 1:07pm |
| flagsmith-frontend-preview | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | May 8, 2024 1:07pm |
| flagsmith-frontend-staging | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | May 8, 2024 1:07pm |
Uffizzi Preview deployment-50354 was deleted.
@kyle-ssg I've just noticed that the change request view doesn't actually show which segment a feature is being overridden by?
Also, is there anything we can do to improve the view when you remove a segment override? I'm just seeing this
@matthewelwell both issues should be resolved now
@kyle-ssg when you create a CR with more than one segment override, the priority values don't seem right.
@kyle-ssg I can't create any change requests now with segment overrides following the latest change:
Related #1204
@kyle-ssg Did we decide to explicitly exclude scheduling changes on segment overrides on environments without change requests enabled?
Editing a feature's state without change requests enabled let you schedule changes:
In comparison, editing segment overrides without change requests only let you make an immediate update: