flagsmith
flagsmith copied to clipboard
feat: add option to disable secure cookies (WIP)
Thanks for submitting a PR! Please check the boxes below:
- [x] I have run
pre-committo check linting - [ ] I have added information to
docs/if required so people know about the feature! - [x] I have filled in the "Changes" section below?
- [x] I have filled in the "How did you test this code" section below?
- [x] I have used a Conventional Commit title for this Pull Request
Changes
Adds an environment variable to disable using secure cookies. This is to be used for deployments inside a private network without a domain / ssl cert.
How did you test this code?
Manually updated project.js to have useSecureCookies: false and ran flagsmith locally, but navigated to it using my local IP, not localhost / 127.0.0.1. Note: this test failed, hence WIP / draft.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| docs | 🛑 Canceled (Inspect) | Feb 26, 2024 5:49pm | ||
| flagsmith-frontend-preview | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Feb 26, 2024 5:49pm |
| flagsmith-frontend-staging | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Feb 26, 2024 5:49pm |
Uffizzi Preview deployment-46906 was deleted.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 95.91%. Comparing base (
a4f2d64) to head (9ebe844).
:exclamation: Current head 9ebe844 differs from pull request most recent head 75344d7. Consider uploading reports for the commit 75344d7 to get more accurate results
Additional details and impacted files
@@ Coverage Diff @@
## main #3441 +/- ##
=======================================
Coverage 95.91% 95.91%
=======================================
Files 1092 1092
Lines 34003 34005 +2
=======================================
+ Hits 32613 32615 +2
Misses 1390 1390
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.