flagsmith icon indicating copy to clipboard operation
flagsmith copied to clipboard

Published 20 hours ago • verified publisher icon Flagsmith

chore: Convert environments permissions views TestCase to normal test function

Open zachaysan opened this issue 1 year ago • 3 comments

Thanks for submitting a PR! Please check the boxes below:

  • [x] I have run pre-commit to check linting
  • [x] ~I have added information to docs/ if required so people know about the feature!~
  • [x] I have filled in the "Changes" section below?
  • [x] I have filled in the "How did you test this code" section below?
  • [x] I have used a Conventional Commit title for this Pull Request

Changes

I'm working through re-writing the TestCase classes into normal test functions. Rewrote the existing TestCase and replaced with fixtures instead of recreating everything. There are other PRs that are similar to this one.

How did you test this code?

I manually changed the tests one at a time to refactor them as I went then ran the full test suite afterwards.

zachaysan avatar Feb 16 '24 20:02 zachaysan

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 20, 2024 3:32pm
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 20, 2024 3:32pm
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 20, 2024 3:32pm

vercel[bot] avatar Feb 16 '24 20:02 vercel[bot]

Uffizzi Preview deployment-46753 was deleted.

github-actions[bot] avatar Feb 16 '24 20:02 github-actions[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (6391ed6) 95.91% compared to head (16884c5) 95.91%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3434      +/-   ##
==========================================
- Coverage   95.91%   95.91%   -0.01%     
==========================================
  Files        1092     1092              
  Lines       34010    33996      -14     
==========================================
- Hits        32622    32608      -14     
  Misses       1388     1388

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Feb 16 '24 20:02 codecov-commenter