flagsmith
flagsmith copied to clipboard
feat: Add has expired column in the api keys table
Thanks for submitting a PR! Please check the boxes below:
- [x] I have run
pre-committo check linting - [x] I have added information to
docs/if required so people know about the feature! - [x] I have filled in the "Changes" section below?
- [x] I have filled in the "How did you test this code" section below?
- [x] I have used a Conventional Commit title for this Pull Request
Changes
- Add API key has expired column in the API keys table
- Related with this https://github.com/Flagsmith/flagsmith/pull/3042#pullrequestreview-1885058591
How did you test this code?
- Go to API keys
The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| docs | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Feb 28, 2024 5:03pm |
| flagsmith-frontend-preview | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Feb 28, 2024 5:03pm |
| flagsmith-frontend-staging | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Feb 28, 2024 5:03pm |
Uffizzi Preview deployment-46718 was deleted.
Is there anything we can do to make this look a bit nicer?
Perhaps expired isn't the correct data point here, maybe we should have an 'active' column which just includes a tick / cross and add a tooltip explaining if it's because it has expired?
Is there anything we can do to make this look a bit nicer?
Perhaps expired isn't the correct data point here, maybe we should have an 'active' column which just includes a tick / cross and add a tooltip explaining if it's because it has expired?
Yes, those are good ideas, I'll make those changes.
Can we align things / make things consistent. The active badge should probably be green, right?
Can we align things / make things consistent. The active badge should probably be green, right?
Done
Perhaps expired isn't the correct data point here, maybe we should have an 'active' column which just includes a tick / cross and add a tooltip explaining if it's because it has expired?
Can we align things / make things consistent. The active badge should probably be green, right?