flagsmith icon indicating copy to clipboard operation
flagsmith copied to clipboard

feat: Add has expired column in the api keys table

Open novakzaballa opened this issue 1 year ago • 2 comments
trafficstars

Thanks for submitting a PR! Please check the boxes below:

  • [x] I have run pre-commit to check linting
  • [x] I have added information to docs/ if required so people know about the feature!
  • [x] I have filled in the "Changes" section below?
  • [x] I have filled in the "How did you test this code" section below?
  • [x] I have used a Conventional Commit title for this Pull Request

Changes

  • Add API key has expired column in the API keys table
  • Related with this https://github.com/Flagsmith/flagsmith/pull/3042#pullrequestreview-1885058591

How did you test this code?

  • Go to API keys

novakzaballa avatar Feb 16 '24 15:02 novakzaballa

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 28, 2024 5:03pm
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 28, 2024 5:03pm
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 28, 2024 5:03pm

vercel[bot] avatar Feb 16 '24 15:02 vercel[bot]

Uffizzi Preview deployment-46718 was deleted.

github-actions[bot] avatar Feb 16 '24 15:02 github-actions[bot]

Is there anything we can do to make this look a bit nicer?

image

Perhaps expired isn't the correct data point here, maybe we should have an 'active' column which just includes a tick / cross and add a tooltip explaining if it's because it has expired?

matthewelwell avatar Feb 26 '24 17:02 matthewelwell

Is there anything we can do to make this look a bit nicer?

image Perhaps expired isn't the correct data point here, maybe we should have an 'active' column which just includes a tick / cross and add a tooltip explaining if it's because it has expired?

Yes, those are good ideas, I'll make those changes.

novakzaballa avatar Feb 26 '24 21:02 novakzaballa

Screen Shot 2024-02-27 at 16 46 20 Hey @matthewelwell I already made the changes, it looks like the image above.

novakzaballa avatar Feb 27 '24 20:02 novakzaballa

image

Can we align things / make things consistent. The active badge should probably be green, right?

matthewelwell avatar Feb 27 '24 21:02 matthewelwell

image Can we align things / make things consistent. The active badge should probably be green, right?
Screen Shot 2024-02-27 at 18 01 20

Done

novakzaballa avatar Feb 27 '24 22:02 novakzaballa