flagsmith icon indicating copy to clipboard operation
flagsmith copied to clipboard

More details in Project Settings view

Open dabeeeenster opened this issue 1 year ago • 14 comments

Is your feature request related to a problem? Please describe.

In the Project Settings view for a project, when you look at "Members", it is possible to distinguish between Regular Users and Project Administrators. However, you can not see the same for a group.

Describe the solution you'd like.

When you look at the group list, we should add a column for whether the group is a Project Administrator or Regular Group.

In addition, it would be really helpful, in the same list view, to see for each user/group if that user/group have any project permissions (View, Create, Delete, Manage, etc.) without having the click on each user or group.

Describe alternatives you've considered

None

Additional context

No response

dabeeeenster avatar Jan 25 '24 15:01 dabeeeenster

In the Project Settings view for a project, when you look at "Members", it is possible to distinguish between Regular Users and Project Administrators. However, you can not see the same for a group.

@dabeeeenster This isn't true, we only distinguish between organisation administrators and normal users but nothing about project permissions.

image

I'm not sure whether we'd need to adjust the designs for this, would we want to show a list of permissions or perhaps Organisation Administrator | Project Administrator | Environment Administrator | x permissions / permission 1, permission 2

kyle-ssg avatar Jan 29 '24 16:01 kyle-ssg

Yes I think here image

we should show a list of what permissions that group has.

dabeeeenster avatar Jan 29 '24 16:01 dabeeeenster

@matthewelwell is this issue open?

jatingodnani avatar Feb 13 '24 09:02 jatingodnani

@jatingodnani absolutely, if you're offering to pick this up! I'll probably be picking this up in around a week if not.

kyle-ssg avatar Feb 15 '24 09:02 kyle-ssg

@kyle-ssg woulb you like to explain me more about this issue

jatingodnani avatar Feb 15 '24 10:02 jatingodnani

@jatingodnani sure.

Essentially in the area Ben mentioned show the following if they are admin of that project/environment

Project Administrator

If they are not, we can show their permissions but truncate to the first 3 as tags e.g.

View Feature, Edit feature, Create Change request, +2 more 

kyle-ssg avatar Feb 20 '24 12:02 kyle-ssg

Hi there! I noticed this open issue and I'm interested in working on it. Would it be possible for someone to assign it to me?

fabricanva avatar Mar 15 '24 01:03 fabricanva

Great thanks - its done!

dabeeeenster avatar Mar 15 '24 08:03 dabeeeenster

Thank you @dabeeeenster, I have submitted a PR for this: https://github.com/Flagsmith/flagsmith/pull/3629

fabricanva avatar Mar 16 '24 00:03 fabricanva

I noticed that in the editPermission file, RTK query is not being used for certain requests (such as creating and updating a group). This could prevent the group and user lists from updating when such changes occur. Would it be advisable for me to create an issue regarding this?

fabricanva avatar Mar 16 '24 00:03 fabricanva

I noticed that in the editPermission file, RTK query is not being used for certain requests (such as creating and updating a group). This could prevent the group and user lists from updating when such changes occur. Would it be advisable for me to create an issue regarding this?

Q for @kyle-ssg and @novakzaballa !

dabeeeenster avatar Mar 16 '24 12:03 dabeeeenster

@fabricanva you're exactly right, I have a couple of PRs in progress migrating things to RTK - related issue https://github.com/Flagsmith/flagsmith/issues/3619

kyle-ssg avatar Mar 26 '24 15:03 kyle-ssg

Reopening as this was progressed in https://github.com/Flagsmith/flagsmith/pull/3629 (thank you so much) but still needs to be done for users

kyle-ssg avatar Mar 26 '24 15:03 kyle-ssg

Reopening as this was progressed in #3629 (thank you so much) but still needs to be done for users

No problem, I can implement it if you'd like @kyle-ssg 😁

fabricanva avatar Mar 26 '24 15:03 fabricanva