flagsmith icon indicating copy to clipboard operation
flagsmith copied to clipboard

feat: Add metadata fields to core entities (API)

Open novakzaballa opened this issue 1 year ago • 4 comments

Thanks for submitting a PR! Please check the boxes below:

  • [x] I have run pre-commit to check linting
  • [x] I have added information to docs/ if required so people know about the feature!
  • [x] I have filled in the "Changes" section below?
  • [x] I have filled in the "How did you test this code" section below?
  • [x] I have used a Conventional Commit title for this Pull Request

Changes

FE changes:

  • https://github.com/Flagsmith/flagsmith/pull/3212

BE changes:

  • Support metadata for segments, and Flags
  • Support required metadata model fields for segments, and Flags

How did you test this code?

Tests added

novakzaballa avatar Jan 23 '24 15:01 novakzaballa

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 13, 2024 9:47pm
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 13, 2024 9:47pm
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 13, 2024 9:47pm

vercel[bot] avatar Jan 23 '24 15:01 vercel[bot]

Uffizzi Preview deployment-44924 was deleted.

github-actions[bot] avatar Jan 23 '24 15:01 github-actions[bot]

Codecov Report

Attention: Patch coverage is 98.06763% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 96.00%. Comparing base (92e3e9f) to head (100f8eb).

Files Patch % Lines
api/segments/serializers.py 91.66% 2 Missing :warning:
api/features/serializers.py 94.11% 1 Missing :warning:
api/metadata/views.py 87.50% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3315      +/-   ##
==========================================
+ Coverage   95.99%   96.00%   +0.01%     
==========================================
  Files        1135     1135              
  Lines       36185    36361     +176     
==========================================
+ Hits        34735    34909     +174     
- Misses       1450     1452       +2     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Jan 23 '24 15:01 codecov-commenter

@gagantrivedi I'm not sure what you're referring to here: https://github.com/Flagsmith/flagsmith/pull/3315#discussion_r1534062976

novakzaballa avatar Mar 21 '24 19:03 novakzaballa