flagsmith icon indicating copy to clipboard operation
flagsmith copied to clipboard

docs: Update doc to add commonLabels and commonAnnotations

Open Viktorsubota opened this issue 1 year ago • 6 comments

Thanks for submitting a PR! Please check the boxes below:

  • [x] I have run pre-commit to check linting
  • [x] I have added information to docs/ if required so people know about the feature!
  • [x] I have filled in the "Changes" section below?
  • [x] I have filled in the "How did you test this code" section below?
  • [x] I have used a Conventional Commit title for this Pull Request

Changes

Updating docs according to the changes made in this PR

How did you test this code?

No tests, as it's just a docs update. The change itself was tested, see its PR.

Viktorsubota avatar Jan 17 '24 11:01 Viktorsubota

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 21, 2024 1:35pm

vercel[bot] avatar Jan 17 '24 11:01 vercel[bot]

Someone is attempting to deploy a commit to the Flagsmith Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Jan 17 '24 11:01 vercel[bot]

Can you check the table formatting with the precommit linter?

dabeeeenster avatar Jan 17 '24 15:01 dabeeeenster

Can you check the table formatting with the precommit linter?

Sure, the pre-commit failed, but I think, it's unrelated. image

Viktorsubota avatar Jan 17 '24 17:01 Viktorsubota

This looks good to me, I've added a comment to the PR on the charts repo with a question but this can be merged once we're happy with the PR on the charts repo. Thanks @Viktorsubota !

Hey @matthewelwell, Sorry, I don't see any comments there.

Could you point me to the one you left? Thanks!

Viktorsubota avatar Jan 18 '24 20:01 Viktorsubota

Hi @Viktorsubota, I think at the time I had forgotten to actually submit the review but I have done that now. Could you check the comment I left there?

matthewelwell avatar Jan 25 '24 11:01 matthewelwell

@dabeeeenster, @matthewelwell, Hey guys, the charts PR got merged, can we merge this PR as well?

Viktorsubota avatar Feb 29 '24 13:02 Viktorsubota