flagsmith icon indicating copy to clipboard operation
flagsmith copied to clipboard

chore: upgrade django

Open SD-13 opened this issue 2 years ago • 5 comments

Fixes #2088 Thanks for submitting a PR! Please check the boxes below:

  • [X] I have run pre-commit to check linting
  • [X] I have filled in the "Changes" section below?
  • [ ] I have filled in the "How did you test this code" section below?
  • [X] I have used a Conventional Commit title for this Pull Request

Changes

I started with upgrading to a new feature release in each step (e.g 2.1 -> 2.2 -> 2.3 -> 4.0) and fixing errors.

How did you test this code?

I am testing the code by running the postgresql db locally and running the tests using the make cmd. And trying to fix the failing tests.

SD-13 avatar Oct 27 '23 15:10 SD-13

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 25, 2023 5:26pm

vercel[bot] avatar Oct 27 '23 15:10 vercel[bot]

@SD-13 is attempting to deploy a commit to the Flagsmith Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Oct 27 '23 15:10 vercel[bot]

I am not sure at this point what to do to fix an error and for that I opened this PR. As you can see in the commit messages I upgraded trench to 0.3.1 to avoid version conflict (ugettext was deprecated in django but the older version was still using it). After that I found that some classes we are using from trench are removed or I would say replaced in the new release (see this commit. So what should we do to fix this, should we try to fit the new classes or look for an alternative? https://github.com/Flagsmith/flagsmith/issues/2088#issuecomment-1757156585

SD-13 avatar Oct 27 '23 18:10 SD-13

Uffizzi Ephemeral Environment Deploying

:cloud: https://app.uffizzi.com/github.com/Flagsmith/flagsmith/pull/2898

:gear: Updating now by workflow run 6979743316.

What is Uffizzi? Learn more!

github-actions[bot] avatar Nov 14 '23 16:11 github-actions[bot]

Hi @matthewelwell I have replied to your comments. The blocker in this PR is that I am not able to figure out how to use the new trench classes introduced in the last trench version. We are using them in api/custom_auth/views.py. Please let me know if you need more context on this. Thanks!

SD-13 avatar Nov 25 '23 19:11 SD-13

@SD-13 thank you for your efforts here but, given the importance of this change, combined with the fact that we'll need to organise notifications to certain customers due to django 4 deprecating postgres 11 support and older versions of oracle, we're going to take this work on internally at Flagsmith.

If you'd like another task to work, please do let me know.

Thanks again!

matthewelwell avatar Feb 26 '24 17:02 matthewelwell

@matthewelwell Thanks for letting me know! and yes, I would like to take some tasks.

SD-13 avatar Feb 27 '24 02:02 SD-13

@SD-13 please check the filtered list here: https://github.com/Flagsmith/flagsmith/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

matthewelwell avatar Feb 27 '24 08:02 matthewelwell