flagsmith icon indicating copy to clipboard operation
flagsmith copied to clipboard

FE changes to add/remove User/Groups to/from Roles

Open novakzaballa opened this issue 2 years ago • 10 comments
trafficstars

Is your feature request related to a problem? Please describe. Currently, the API supports adding users and groups to roles however in the frontend we don't have a way to do it.

Describe the solution you'd like

In the management option of the top bar, when the admin goes to the members tab, we should display a roles sub-tab, When an admin edits a role, a modal is shown, and in the first tab, where the name and description of the role are shown, we need to allow the admin to add and remove users and/or groups to the role.

Additional context Initially, the ability to add and remove users/groups will reside only on the roles sub-tab of the members tab, in the screen shown when an admin clicks on the Management top menu option

novakzaballa avatar Sep 07 '23 02:09 novakzaballa

Image

Image

Image

Image

@kyle-ssg @matthewelwell

novakzaballa avatar Sep 11 '23 14:09 novakzaballa

I think this is fine for now, but might get a bit cluttered for larger teams. We may need to rethink it at that point but, for the initial release, I think this is fine.

matthewelwell avatar Sep 11 '23 15:09 matthewelwell

We'll also need to implement the functionality from the other side - adding roles directly to a user or a group.

matthewelwell avatar Sep 11 '23 15:09 matthewelwell

Image

Image

novakzaballa avatar Sep 12 '23 13:09 novakzaballa

The above designs show how we would add roles to users and groups

novakzaballa avatar Sep 12 '23 13:09 novakzaballa

@novakzaballa @dabeeeenster I think this might need a bit more thought from a design perspective. Can you guys organise?

matthewelwell avatar Sep 12 '23 16:09 matthewelwell

@dabeeeenster new designs show how we would add users to roles and manage roles in project and environment

Image Image Image Image

novakzaballa avatar Sep 14 '23 22:09 novakzaballa

@novakzaballa are these pushed to the PR? Can you link this issue to the PR too?

dabeeeenster avatar Sep 15 '23 08:09 dabeeeenster

@dabeeeenster this is the PR: https://github.com/Flagsmith/flagsmith/pull/2791

novakzaballa avatar Sep 22 '23 14:09 novakzaballa

This issue was closed but I believe the "show_role_management" feature should be enabled?

kyle-ssg avatar Jan 25 '24 15:01 kyle-ssg