flagsmith icon indicating copy to clipboard operation
flagsmith copied to clipboard

Create change requests updates variation value for the whole project

Open gagantrivedi opened this issue 2 years ago • 6 comments

Describe the bug

For an environment with change request enabled, if the user updates any of the variation values and clicks the crate change request button variation values are updated without any warning(since they are not covered by change request)

To Reproduce

Steps to reproduce the behavior:

  1. Create a multi variate feature with change request enabled
  2. Click on the feature toggle
  3. Update the variation value
  4. Click on Create change request

Expected behavior

There should either be a different button or some sort of warning to let the user know that variation value updates are not covered by change requests.

Screenshots

If applicable, add screenshots to help explain your problem. Screenshot_20230726_143611

How are you running Flagsmith?

  • [ ] Self Hosted with Docker
  • [ ] Self Hosted with Kubernetes
  • [x] SaaS at flagsmith.com
  • [ ] Some other way

Additional context

Add any other context about the problem here.

gagantrivedi avatar Jul 26 '23 09:07 gagantrivedi

@novakzaballa , after discussing this issue. Can we display a button next to create change request labelled "Update Variation Values" when MV values(not the %) are adjusted.

  • createChange's call AppActions.editFeatureMv should not update any existing mv-options but it should still create new ones (the default allocation of mv options is 0 so this isn't harmful)
  • The Update Variation Values should call AppActions.editFeatureMv

kyle-ssg avatar Jul 26 '23 12:07 kyle-ssg

Sure. Should we display a confirmation dialog like in other cases and display the message there so users are more aware?

dabeeeenster avatar Jul 26 '23 12:07 dabeeeenster

Edited suggestion above

kyle-ssg avatar Jul 26 '23 12:07 kyle-ssg

Hi @dabeeeenster, I would like to work on this issue. Can you please assign this issue to me?

jainpawan21 avatar Aug 01 '23 18:08 jainpawan21

Sure - @novakzaballa can you do this if you've not started yet?

dabeeeenster avatar Aug 01 '23 18:08 dabeeeenster

Sure, assigned to @jainpawan21

novakzaballa avatar Aug 01 '23 19:08 novakzaballa