flagsmith
flagsmith copied to clipboard
Create change requests updates variation value for the whole project
Describe the bug
For an environment with change request enabled, if the user updates any of the variation values and clicks the crate change request button variation values are updated without any warning(since they are not covered by change request)
To Reproduce
Steps to reproduce the behavior:
- Create a multi variate feature with change request enabled
- Click on the feature toggle
- Update the variation value
- Click on
Create change request
Expected behavior
There should either be a different button or some sort of warning to let the user know that variation value updates are not covered by change requests.
Screenshots
If applicable, add screenshots to help explain your problem.
How are you running Flagsmith?
- [ ] Self Hosted with Docker
- [ ] Self Hosted with Kubernetes
- [x] SaaS at flagsmith.com
- [ ] Some other way
Additional context
Add any other context about the problem here.
@novakzaballa , after discussing this issue. Can we display a button next to create change request labelled "Update Variation Values" when MV values(not the %) are adjusted.
- createChange's call AppActions.editFeatureMv should not update any existing mv-options but it should still create new ones (the default allocation of mv options is 0 so this isn't harmful)
- The Update Variation Values should call AppActions.editFeatureMv
Sure. Should we display a confirmation dialog like in other cases and display the message there so users are more aware?
Edited suggestion above
Hi @dabeeeenster, I would like to work on this issue. Can you please assign this issue to me?
Sure - @novakzaballa can you do this if you've not started yet?
Sure, assigned to @jainpawan21