flagsmith icon indicating copy to clipboard operation
flagsmith copied to clipboard

Published 20 hours ago • verified publisher icon Flagsmith

Upgrade to Django 4.2

Open matthewelwell opened this issue 1 year ago • 11 comments

https://www.djangoproject.com/weblog/2023/apr/03/django-42-released/

Known TODOs:

  • Replace / remove third party pytest plugin with the one available in pytest-django here

matthewelwell avatar Apr 03 '23 12:04 matthewelwell

Hey! I'd like to work over this issue. Does this include just upgrading django to 4.2 and running all the security checks afterwards if code working properly or not?

oohsai avatar Aug 17 '23 19:08 oohsai

Yep - getting all the Github Action tests to pass!

dabeeeenster avatar Aug 17 '23 19:08 dabeeeenster

@matthewelwell @dabeeeenster I want to work on this. please let me if it's available. Thanks!

SD-13 avatar Aug 23 '23 20:08 SD-13

Hi @SD-13 , I don't know if @oohsai is working on it already? If so, please assign to yourself. If not, @SD-13 feel free to take it.

matthewelwell avatar Aug 23 '23 20:08 matthewelwell

Hey @SD-13, Started Working on it but As I'm just startin off with open source. You can assign this issue to yourself. Just a humble request to drop on how you resolved this issue would be of great help.

oohsai avatar Aug 24 '23 03:08 oohsai

Hey @SD-13, Started Working on it but As I'm just startin off with open source. You can assign this issue to yourself. Just a humble request to drop on how you resolved this issue would be of great help.

oohsai avatar Aug 24 '23 03:08 oohsai

@oohsai sure thing 😃. @matthewelwell Can you please assign me. Thanks!

SD-13 avatar Aug 24 '23 05:08 SD-13

@oohsai sure thing 😃. @matthewelwell Can you please assign me. Thanks!

Here you go!

gagantrivedi avatar Aug 24 '23 05:08 gagantrivedi

I am upgrading django versions incrementally by fixing errors in each version. As part of that, I upgraded django to 4.0 and django-trench from 0.2.3 to 0.3.0 and now I am getting this error

ImportError: cannot import name 'AuthTokenLoginOrRequestMFACode' from 'trench.views.authtoken'

After digging a bit I found that, the AuthTokenLoginOrRequestMFACode and AuthTokenLoginWithMFACode is removed in this PR. So what should we do in this case?

SD-13 avatar Oct 11 '23 08:10 SD-13

I am upgrading django versions incrementally by fixing errors in each version. As part of that, I upgraded django to 4.0 and django-trench from 0.2.3 to 0.3.0 and now I am getting this error

ImportError: cannot import name 'AuthTokenLoginOrRequestMFACode' from 'trench.views.authtoken'

After digging a bit I found that, the AuthTokenLoginOrRequestMFACode and AuthTokenLoginWithMFACode is removed in this PR. So what should we do in this case?

@SD-13 can you add the PR in which it was removed?

gagantrivedi avatar Oct 13 '23 02:10 gagantrivedi

@SD-13 can you add the PR in which it was removed?

@gagantrivedi https://github.com/merixstudio/django-trench/pull/115

For now, I am trying the changes in this PR

SD-13 avatar Oct 13 '23 05:10 SD-13

This was previously blocked by the postgres engine upgrade and determining oracle support. These are now complete so we can work on this upgrade.

matthewelwell avatar May 08 '24 12:05 matthewelwell